Change delz dimension corresponding to the change in atmos_cubed_sphere#397
Merged
Conversation
This was referenced Feb 13, 2020
Merged
XiaqiongZhou-NOAA
requested review from
JulieSchramm,
climbfuji,
grantfirl and
llpcarson
as code owners
climbfuji
requested changes
May 13, 2020
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
This PR also needs to be updated with the latest version of NCAR ccpp-physics master.
climbfuji
reviewed
May 14, 2020
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
This looks good to me, thanks! Will approve when regression tests passed.
Collaborator
|
@grantfirl @llpcarson @XiaqiongZhou-NOAA in case the dycore merge PRs make it to the top of the commit queue during my two days of vacation, please communicate with each other to approve and merge this PR. Also talk to @DusanJovic-NOAA and @junwang-noaa. Thanks! |
climbfuji
approved these changes
May 27, 2020
climbfuji
approved these changes
Jun 9, 2020
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Code in PR has been updated with the latest changes from master, approved.
hannahcbarnes
pushed a commit
to hannahcbarnes/ccpp-physics
that referenced
this pull request
Aug 3, 2022
* update ccpp with decomposition fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To update FV3 dynamic core, change delz dimension corresponding to the change in atmos_cubed_sphere
Related pull requests:
atmos_cubed_sphere #15
universe-weather-model #58
fv3atm #65