Feature/hafs ccpp#390
Conversation
BinLiu-NOAA
requested review from
JulieSchramm,
climbfuji,
grantfirl and
llpcarson
as code owners
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
I noted two aspects that we would usually ask you to change. However, given that @grantfirl and his colleagues are working on a unification of moninedmf_hafs and moninedmf, I assume they will cover those aspects and I think it is not necessary for you to make those changes. I will try to pull your PR into dtc/develop instead of master to expedite merging it.
| ! | ||
| use machine , only : kind_phys | ||
| use funcphys , only : fpvs | ||
| use physcons, grav => con_g, rd => con_rd, cp => con_cp & |
There was a problem hiding this comment.
These constants should be passed in via the argument list.
| !> \ingroup PBL | ||
| !! \brief Routine to solve the tridiagonal system to calculate temperature and moisture at \f$ t + \Delta t \f$; part of two-part process to calculate time tendencies due to vertical diffusion. | ||
| !! | ||
| !! Origin of subroutine unknown. |
There was a problem hiding this comment.
These tridiagonal matrix calculation functions could be merged into tridi.f.
Hi Dom, Thanks for the comments and suggestions for moving forward. Looking forward to @grantfirl and Biswas's help to come up an unified moninedmf version. Bin |
|
@BinLiu-NOAA @climbfuji Both of the concerns raised by Dom are addressed in PR #395 which should be regarded as a followup to this PR. Feel free to look at the code changes there if you want. I'd like to go ahead and approve this PR to give credit to @BinLiu-NOAA and colleagues for doing this work and to have the HAFS-specific version in the repository if needed later. In addition, having this version in the repo can serve as a basis for regressiont testing PR #395 to make sure the combined version behaves identically to the HAFS-specific version with the hurr_pbl flag turned on and alpha set appropriately, and the GFS version when hurr_pbl is false. I'd like for PR #395 to supercede this one once that testing is satisfactory. |
3 participants
Connect HAFS version of GFS EDMF PBL scheme with CCPP (from @Qingfu-Liu, Bin, Chunxi, and Weiguo).
Files added/modified:
physics/moninedmf_hafs.f
physics/moninedmf_hafs.meta
Notes: