Skip to content

fix array dimensions for phii, prsi in ugwp_driver_v0.F #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
climbfuji merged 1 commit into from
Dec 9, 2019
Merged

fix array dimensions for phii, prsi in ugwp_driver_v0.F #368

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion physics/ugwp_driver_v0.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,9 @@ subroutine cires_ugwp_driver_v0(me, master,
&, rain

real(kind=kind_phys), intent(in), dimension(im,levs) :: ugrs
&, vgrs, tgrs, qgrs, prsi, prsl, prslk, phii, phil, del
&, vgrs, tgrs, qgrs, prsl, prslk, phil, del
Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji Dec 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting that this code is commented out (ifdef-ed out) in ccpp-physics: the entire block lines 16-253 (subroutine cires_ugwp_driver_v0) is not used in CCPP.

The corresponding code in cires_ugwp.{F90,meta} has the correct dimensions for phii and prsi.

Copy link
Copy Markdown
Collaborator Author

@grantfirl grantfirl Dec 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely did not notice that! Wouldn't that explain why debug mode compilation wouldn't catch this? I'm guessing that the associated PR for the non-CCPP version is exercised though?

real(kind=kind_phys), intent(in), dimension(im,levs+1) ::
& phii, prsi

! real(kind=kind_phys), intent(in) :: oro_stat(im,nmtvr)
real(kind=kind_phys), intent(in), dimension(im) :: hprime, oc
Expand Down