fix no-MPI compilation for F-A scheme#363
Merged
Merged
Conversation
grantfirl
requested review from
JulieSchramm,
climbfuji and
llpcarson
as code owners
grantfirl
commented
Dec 2, 2019
| write(0,*)' ABORTING!' | ||
| #ifdef MPI | ||
| call MPI_ABORT(MPI_COMM_COMP, rc, IRTN) | ||
| #endif |
Collaborator
Author
There was a problem hiding this comment.
I suppose that I could put an #else STOP here?
Collaborator
Author
There was a problem hiding this comment.
Or, set ccpp_errflg/msg and return since we're not supposed to STOP in a scheme?
Collaborator
There was a problem hiding this comment.
I think we should do that in either case - set errmsg and errflg and return, not even worrying about MPI_ABORT or STOP.
Collaborator
|
@grantfirl I already merged the PR for SCM. I will thus merge this PR as a temporary fix and hope for another PR that uses errmsg/errflg instead of aborting the model. Thanks! |
climbfuji
approved these changes
Dec 3, 2019
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Approved as temporary workaround.
hannahcbarnes
pushed a commit
to hannahcbarnes/ccpp-physics
that referenced
this pull request
Aug 3, 2022
lisa-bengtsson
pushed a commit
to lisa-bengtsson/ccpp-physics
that referenced
this pull request
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMO, no RTs required.