Skip to content

Replacement PR for "Implement Ferrier-Aligo MP scheme in CCPP-Physics" from @mzhangw (squashed commits)#358

Merged
climbfuji merged 1 commit into
NCAR:dtc/developfrom
climbfuji:man_fa_squashed
Nov 22, 2019
Merged

Replacement PR for "Implement Ferrier-Aligo MP scheme in CCPP-Physics" from @mzhangw (squashed commits)#358
climbfuji merged 1 commit into
NCAR:dtc/developfrom
climbfuji:man_fa_squashed

Conversation

@climbfuji
Copy link
Copy Markdown
Collaborator

This PR is a replacement for #352 from @mzhangw in which the commit history was squashed into one clean commit.

It adds the Ferrier-Aligo microphysics scheme and make corresponding changes in interstitial and radiation code. The code in this PR is identical to that in the original PR #352.

The original PR was tested with several other commits:
NCAR/GFDL_atmos_cubed_sphere#5
NCAR/fv3atm#2
NCAR/ufs-weather-model#1

…onding changes in interstitial and radiation code
@climbfuji
Copy link
Copy Markdown
Collaborator Author

$ diff ccpp-physics-fa-from-man/ ccpp-physics-dtc-develop-merge-fa/
Common subdirectories: ccpp-physics-fa-from-man/.git and ccpp-physics-dtc-develop-merge-fa/.git
Common subdirectories: ccpp-physics-fa-from-man/physics and ccpp-physics-dtc-develop-merge-fa/physics

@climbfuji climbfuji requested a review from mzhangw November 22, 2019 23:00
Copy link
Copy Markdown
Contributor

@mzhangw mzhangw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@climbfuji climbfuji merged commit ed8d6b9 into NCAR:dtc/develop Nov 22, 2019
@climbfuji climbfuji deleted the man_fa_squashed branch June 27, 2022 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants