Skip to content

add initial NoahMP docs to CCPP scientific docs#345

Merged
climbfuji merged 3 commits into
NCAR:dtc/developfrom
grantfirl:NoahMP_docs
Dec 9, 2019
Merged

add initial NoahMP docs to CCPP scientific docs#345
climbfuji merged 3 commits into
NCAR:dtc/developfrom
grantfirl:NoahMP_docs

Conversation

@grantfirl
Copy link
Copy Markdown
Collaborator

@grantfirl grantfirl commented Oct 25, 2019 •
edited
Loading

  • Add NoahMP to "all schemes" list
  • wrote stub for NoahMP "landing page"
  • landing page points to existing NCAR NoahMP documentation and main paper
  • landing page also documents the "MP" options chosen by EMC
  • Doxygen configuration file edited to find NoahMP source code and landing page
  • Library.bib updated with NoahMP references
  • added Doxygen markup to put all NoahMP-related subroutines in NoahMP doxygen group
  • minor code change in module_sf_noahmplsm.f90 for doxygen to be able to parse the file
  • added brief descriptions and general algorithm section for subroutines in sfc_noahmp_drv.f

@grantfirl
Copy link
Copy Markdown
Collaborator Author

grantfirl commented Oct 25, 2019

@mzhangw Added as reviewer to make sure I'm not doing something wrong

@grantfirl grantfirl requested a review from mzhangw October 25, 2019 23:16
@grantfirl
Copy link
Copy Markdown
Collaborator Author

grantfirl commented Oct 25, 2019

TODO:

  • write brief descriptions for main subroutines within NoahMP code
  • incorporate potential additions/edits from EMC colleagues
  • incorporate potential additions from Mike Barlage
  • add NoahMP namelist parameters to "Namelist Options Description" page?

@grantfirl
Copy link
Copy Markdown
Collaborator Author

grantfirl commented Oct 25, 2019

@ligiabernardet Note that what is currently here might be sufficient for purposes of the release since it covers the basics. I wouldn't classify it as done, since there are things that could be added to improve, but this is a reasonable place to start for a non-operational scheme (although it should definitely be finished by the time GFS v16 goes operational).

@climbfuji
Copy link
Copy Markdown
Collaborator

climbfuji commented Dec 5, 2019

@grantfirl @ligiabernardet @mzhangw can this be merged now?

@climbfuji
Copy link
Copy Markdown
Collaborator

climbfuji commented Dec 6, 2019

I would like to pull this into #366 and merge it into dtc/develop as it is now. Please let me know if that's ok.

@grantfirl grantfirl changed the base branch from gmtb/develop to dtc/develop December 6, 2019 04:05
@grantfirl
Copy link
Copy Markdown
Collaborator Author

grantfirl commented Dec 6, 2019

Just put in an update to reflect info from Helin. Let me run doxygen real quick to verify it looks OK.

@grantfirl
Copy link
Copy Markdown
Collaborator Author

grantfirl commented Dec 6, 2019

@climbfuji All good for now.

@climbfuji
Copy link
Copy Markdown
Collaborator

climbfuji commented Dec 6, 2019

This PR has been pulled into #366

@climbfuji climbfuji mentioned this pull request Dec 6, 2019
Merged
climbfuji
climbfuji approved these changes Dec 8, 2019
View reviewed changes
Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not merge this PR as it will be merged automatically with #366.

@climbfuji climbfuji merged commit e0e91d8 into NCAR:dtc/develop Dec 9, 2019
hannahcbarnes pushed a commit to hannahcbarnes/ccpp-physics that referenced this pull request Aug 3, 2022
@junwang-noaa
Flexible output hour for history files (NCAR#345)
f8732ff 
* add flexibile output time
* add fcst_mpi_comm to GFS_init_type Init_parm in atmos_model_init, remove commglobal communicator
* update output_fh for fms history output,  fix output_startfh initialization
BinLiu-NOAA pushed a commit to hafs-community/ccpp-physics that referenced this pull request Feb 23, 2026
@grantfirl
Merge pull request NCAR#345 from XiaSun-Atmos/feature/mynn_sfc_submodule
fa51a56 
Feature/mynn sfc submodule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@climbfuji climbfuji climbfuji approved these changes

@JulieSchramm JulieSchramm Awaiting requested review from JulieSchramm

@llpcarson llpcarson Awaiting requested review from llpcarson

@mzhangw mzhangw Awaiting requested review from mzhangw

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@grantfirl @climbfuji