Added sea_land_ice_mask to sfc_drv_ruc.F90#334
Merged
Conversation
… be used in the check for consistency of land information.
climbfuji
approved these changes
Oct 8, 2019
Collaborator
climbfuji
left a comment
There was a problem hiding this comment.
Looks good to me. This will change the answer for the ccpp_gsd regression tests. The commit is for the gsd/develop branch, not for master, I updated the target branch accordingly.
Collaborator
|
Note - until we update the submodule pointer for the NEMSfv3gfs gsd/develop branch, these changes won't be included when the code is checked out in the usual way: |
Collaborator
|
Note: this PR includes but does not mention the changes from #332 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sea_land_ice mask was added to the consistency check on the vegetation type for land points:
if (land(i) .and. (vegtype(i)==iswater .or. (vegtype(i)==isice.and.islimsk(i)==2))) then
!write(errmsg,'(a,i0,a,i0)') 'Logic error in sfc_drv_ruc_run: for i=', i, &
! ', land(i) is true but vegtype(i) is water or ice: ', vegtype(i)
!errflg = 1
!return
if(flag_init .and. iter==1) then
write(0,'(a,i0,a,i0)') 'Warning: in sfc_drv_ruc_run: for i=', i, &
', land(i) is true but vegtype(i) is water or ice: ', vegtype(i)
end if
end if
The vegetation type for ice (isice=15) could be for both land and sea ice points. Therefore, additional check is added to warn only on the sea ice points with land=.true.
This change will preclude from multiple unnecessary warning prints.