Address issue #300#302
Merged
Merged
Conversation
…he code for RUC LSM); change units of soil moisture content and runoff variables to kg m-2 (CCPP metadata had been in error and they only were in kg m-2 after a conversion in GFS_diagnostics.F90); should be merged with removal of conversion factor in GFS_diagnostics.F90 in FV3 repo
Collaborator
Author
|
Associated PR: https://github.com/NCAR/FV3/pull/189 |
grantfirl
added
do not merge
work in progress
and removed
do not merge
work in progress
labels
Collaborator
Author
|
Passed fv3_control, fv3_gfdlmprad_noahmp tests in IPD PROD mode and fv3_ccpp_control in CCPP PROD mode to exercise changes to Noah LSM and Noah MP LSM (did not run a RUC LSM test), so should be reasonably good to test further in combination with other PRs. Note that the equivalent code changes for Noah MP test with CCPP will be tested with the Noah MP CCPP compliancy PR (#305). |
hannahcbarnes
pushed a commit
to hannahcbarnes/ccpp-physics
that referenced
this pull request
Aug 3, 2022
…ile UPDATED with head of DEVELOP (NCAR#302) - Add compatibility/consistency checks for namelists in different CCPP schemes. For example, `do_ysu` needs to set to `true` when `ysudif` scheme is used in the suite definition files. - Fix a typo in GFS_typedefs.meta: imfshalcnv_ntiedtke is typed as imfshalcnv_gf. - Integer options for PBL and surface layer schemes are not implemented. Co-authored-by: XiaSun-NOAA <xia.sun@noaa.gov>
dustinswales
pushed a commit
to dustinswales/ccpp-physics
that referenced
this pull request
Jul 21, 2025
Combination of 264,265,291 (MERRA2 3-hr, photochem diag, prog closure SFS)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change units of runoff fluxes to kg m-2 s-1 in the metadata (and in the code for RUC LSM); change units of soil moisture content and runoff variables to kg m-2 (CCPP metadata had been in error and they only were in kg m-2 after a conversion in GFS_diagnostics.F90); should be merged with removal of conversion factor in GFS_diagnostics.F90 in FV3 repo