Bug fix: use public interface to ccpp_fields_get_#3
Closed
llpcarson wants to merge 6 commits into
Closed
Conversation
In the gfsphyics IPD_driver_cap.f90 there were two references to
"ccpp_fields_get_ptr":
https://github.com/NCAR/gmtb-gfsphysics/blob/features/ccpp/IPD_layer/IPD_driver_cap.f90
lines 246 & 309.
The subroutine is not public. I (Tim) wrapped it with an interface/module
procedure as ccpp_fields_get() so as to be able to get an int, real,
logical and pointer. We should not be calling the _ptr subroutine.
modified: IPD_layer/IPD_driver_cap.f90
modified: IPD_layer/IPD_driver_cap.f90
Contributor
Author
|
This PR is superceded by Tim's PR (#6) |
hannahcbarnes
pushed a commit
to hannahcbarnes/ccpp-physics
that referenced
this pull request
Apr 7, 2020
…3D reflectivity to restart file and restart reproducibility for regional fv3,3)ufs issue NCAR#5, Updates to WW3, 4)vlab #69735, update netcdf time units attribute when iau_offset
hannahcbarnes
pushed a commit
to hannahcbarnes/ccpp-physics
that referenced
this pull request
Apr 7, 2020
Add SAS deep/shallow convection and satmedmfvdifq (updated version of satmedmfvdif) to CCPP
llpcarson
referenced
this pull request
in llpcarson/ccpp-physics
Dec 22, 2020
Suggested changes to rucice PR
climbfuji
pushed a commit
that referenced
this pull request
Aug 11, 2021
Constant branch update from Dom 2021/08/02
climbfuji
pushed a commit
that referenced
this pull request
Dec 20, 2021
Update cloud_cover_xr with latest change from NCAR ccpp-physics main
grantfirl
pushed a commit
that referenced
this pull request
Feb 23, 2022
Fix the rest of the Cheyenne/GNU tests
AnningCheng-NOAA
added a commit
that referenced
this pull request
Apr 5, 2022
Update to mraerosol branch from Dom
hannahcbarnes
pushed a commit
to hannahcbarnes/ccpp-physics
that referenced
this pull request
Aug 3, 2022
Update .gitmodules and submodule pointer for ccpp-physics for code review and testing
XiaqiongZhou-NOAA
pushed a commit
to XiaqiongZhou-NOAA/ccpp-physics
that referenced
this pull request
May 30, 2023
Cray compiler fix
bluefinweiwei
pushed a commit
to bluefinweiwei/ccpp-physics
that referenced
this pull request
Jul 18, 2023
Revert combination, update to ufs/dev, and update CODEOWNERS
XiaqiongZhou-NOAA
pushed a commit
to XiaqiongZhou-NOAA/ccpp-physics
that referenced
this pull request
Jul 11, 2024
Random fixes for HR4 GWD update
vyudinspb
pushed a commit
to vyudinspb/ccpp-physics
that referenced
this pull request
May 8, 2025
addressing typo that prevented compilation
XiaqiongZhou-NOAA
pushed a commit
to XiaqiongZhou-NOAA/ccpp-physics
that referenced
this pull request
Jan 22, 2026
fix bug in GFS_surface_composites_pre.F90
mkavulich
pushed a commit
to mkavulich/ccpp-physics
that referenced
this pull request
Mar 3, 2026
Feature/aqm canopy vdf updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix: