HAFS physics changes for CCPP#287
Closed
climbfuji wants to merge 2 commits into
Closed
Conversation
…ert windows linebreak characters to unix linebreak characters
grantfirl
reviewed
Jul 31, 2019
| errflg = 1 | ||
| write(errmsg,'(*(a))') 'Logic error: moninq_fac == 0', | ||
| & ' is incompatible with hedmf' | ||
| end if |
Collaborator
There was a problem hiding this comment.
Presumably, moninq_fac is set to 0 in the physics namelist when using HAFS? This isn't obvious from this PR.
Collaborator
Author
There was a problem hiding this comment.
Yes, and if moninq_fac is zero the code in this version of hedmf doesn't make sense.
grantfirl
approved these changes
Jul 31, 2019
Collaborator
grantfirl
left a comment
grantfirl
left a comment
There was a problem hiding this comment.
These changes (except for the whitespace changes in moninedmf.f) seem fine to me with the caveat that they should be used in conjunction with a yet-to-be done new version of moninedmf.
Collaborator
Author
|
The "whitespace" changes are a conversion from windows line endings back to unix line endings. Somehow someone introduced those in the past. Never open code in windows. |
Collaborator
Author
|
This PR is replaced by #317 |
hannahcbarnes
pushed a commit
to hannahcbarnes/ccpp-physics
that referenced
this pull request
Aug 3, 2022
* gitmodule to climbfuji/flake_from_yihua and ccpp/physics pointer update * new pointer update * Pointer update * updated pointer to NCAR/ccpp-physics and reverted .gitmodules
XiaqiongZhou-NOAA
pushed a commit
to XiaqiongZhou-NOAA/ccpp-physics
that referenced
this pull request
Jun 25, 2025
Slight modification in orographic gravity wave drag (OGWD) scheme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes for the hurricane physics were recently made in the IPD version of GFS physics. This PR makes the corresponding changes in sfc_diff.f and adds a guard to prevent using the original moninedmf.f with the hurricane physics.
It is understood that the new moninedmf required to run the hurricane physics (moninedmf_hafs.f in IPD) should be combined with the existing moninedmf in CCPP to avoid the duplication of code. This will be addressed in a follow-up pull request when other schemes required for hurricane applications (e.g. Ferrier-Aligo microphysics) will be added.
This PR requires changes in the Vlab FV3 repository and must be merged at the same time (or afterwards), see issue https://vlab.ncep.noaa.gov/redmine/issues/66372.