Remove stochastic_physics from CCPP#284
Closed
climbfuji wants to merge 1 commit into
Closed
Conversation
grantfirl
approved these changes
Jul 31, 2019
Collaborator
grantfirl
left a comment
grantfirl
left a comment
There was a problem hiding this comment.
Approved for when this is ready to merge.
Collaborator
Author
|
This PR is replaced by #317 |
hannahcbarnes
pushed a commit
to hannahcbarnes/ccpp-physics
that referenced
this pull request
Aug 3, 2022
…n CCPP (NCAR#284) This PR removes one entry from the ccpp_prebuild_config.py that is no longer required, and updates the submodule pointer for ccpp-physics for the changes described in NCAR#611. Also included: * workaround to propagate REPRO/Bitforbit mode correctly to CCPP - will be cleaned up in @DusanJovic-NOAA's next PR * tiny bugfix for aux3d arrays (active attribute in CCPP metadata was wrong), no impact on any of the tests, this is just a debugging feature Co-authored-by: Dustin Swales <dustin.swales@noaa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to the separation of the NOAA/ESRL/PSD stochastic physics code from the FV3 repository on Vlab into its own repository on GitHub (https://github.com/noaa-psd/stochastic_physics).
For ccpp-physics, this requires only the removal of the entire
stochastic_physicsdirectory.A detailed description of this change can be found in https://vlab.ncep.noaa.gov/redmine/issues/65851.
Merging this PR requires coordination with merging the changes in NEMSfv3gfs and FV3, hence I have added the "do not merge" flag to this PR. The changes can be reviewed and approved anytime, I will remove the "do not merge" flag and merge the PR once EMC is ready to accept the NEMSfv3gfs and FV3 changes.