Skip to content

Bugfix GF convection, Thompson cleanup 2019/07/09#283

Merged
climbfuji merged 5 commits into
NCAR:gmtb/developfrom
climbfuji:bugfix_gf_conv_AND_thompson_cleanup_20190709
Jul 16, 2019
Merged

Bugfix GF convection, Thompson cleanup 2019/07/09#283
climbfuji merged 5 commits into
NCAR:gmtb/developfrom
climbfuji:bugfix_gf_conv_AND_thompson_cleanup_20190709

Conversation

@climbfuji
Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji commented Jul 9, 2019

This PR and associated PRs listed below fix a bug in the GF convection scheme introduced in a previous code cleanup PR (#251) and cleans up/improves code for the CCPP Thompson MP scheme.

  • physics/GFS_PBL_generic.F90: add missing tracers for Thompson MP to tracer advection array for PBL schemes
  • physics/cu_gf_deep.F90: bugfix, replace exit statements in do loop with cycle statements
  • physics/cu_gf_driver.F90: cleanup, instead of passing in convective_transportable_tracers array, only pass in the components required
  • physics/cu_ntiedtke.F90, physics/samfdeepcnv.f, physics/samfshalcnv.f: add notes to check dimensions of clw array
  • physics/module_mp_thompson.F90, physics/mp_thompson.F90: cleanup, return with an error if CCN_ACTIVATE.BIN is not found, remove temporary stopping of model

Testing: logs will be posted below

Associated PRs:
https://github.com/NCAR/NEMSfv3gfs/pull/199
https://github.com/NCAR/FV3/pull/176
#283

climbfuji added 5 commits July 9, 2019 10:11
…ransportable_tracers array, only pass in the components required
…: add notes to check dimensions of clw array
…urn with an error if CCN_ACTIVATE.BIN is not found, remove temporary stopping of model
@climbfuji
Copy link
Copy Markdown
Collaborator Author

Testing on MacOSX/GNU: bit-for-bit identical results through restarts for both the GSD_v0 suite and the GSD_noah (i.e. GSD suite with Noah LSM instead of RUC LSM).

@climbfuji climbfuji marked this pull request as ready for review July 15, 2019 21:15
@climbfuji
Copy link
Copy Markdown
Collaborator Author

NEMSCompsetRun test on Theia against official baseline: all pass (including one CCPP test, but no GSD suite test).

NEMSCompsetRun.log

@climbfuji
Copy link
Copy Markdown
Collaborator Author

CCPP-GSD tests (create and verify, including restart runs) all PASS on Theia/Intel

rt_ccpp_gsd_verify.log
rt_ccpp_gsd_create.log

@climbfuji
Copy link
Copy Markdown
Collaborator Author

CCPP-GMTB tests (create in static mode, verify in static and dynamic mode) all PASS on Theia/Intel

rt_ccpp_gmtb_verify.log
rt_ccpp_gmtb_create.log

@climbfuji
Copy link
Copy Markdown
Collaborator Author

climbfuji commented Jul 16, 2019

Regression tests against official baseline on Theia/Intel PASS except fv3_ccpp_gsd tests - this is to be expected because of the changes for Thompson MP and the bugfixes for GF convection.

rt.log

This PR is ready for review and merging.

Copy link
Copy Markdown
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Again, sorry for the loop exit bug!

@climbfuji climbfuji merged commit 0882030 into NCAR:gmtb/develop Jul 16, 2019
@climbfuji climbfuji deleted the bugfix_gf_conv_AND_thompson_cleanup_20190709 branch June 27, 2022 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants