Bugfix GF convection, Thompson cleanup 2019/07/09#283
Conversation
…racer advection array for PBL schemes
…th cycle statements
…ransportable_tracers array, only pass in the components required
…: add notes to check dimensions of clw array
…urn with an error if CCN_ACTIVATE.BIN is not found, remove temporary stopping of model
|
Testing on MacOSX/GNU: bit-for-bit identical results through restarts for both the GSD_v0 suite and the GSD_noah (i.e. GSD suite with Noah LSM instead of RUC LSM). |
|
NEMSCompsetRun test on Theia against official baseline: all pass (including one CCPP test, but no GSD suite test). |
|
CCPP-GSD tests (create and verify, including restart runs) all PASS on Theia/Intel |
|
CCPP-GMTB tests (create in static mode, verify in static and dynamic mode) all PASS on Theia/Intel |
|
Regression tests against official baseline on Theia/Intel PASS except fv3_ccpp_gsd tests - this is to be expected because of the changes for Thompson MP and the bugfixes for GF convection. This PR is ready for review and merging. |
grantfirl
left a comment
There was a problem hiding this comment.
Looks good to me. Again, sorry for the loop exit bug!
This PR and associated PRs listed below fix a bug in the GF convection scheme introduced in a previous code cleanup PR (#251) and cleans up/improves code for the CCPP Thompson MP scheme.
Testing: logs will be posted below
Associated PRs:
https://github.com/NCAR/NEMSfv3gfs/pull/199
https://github.com/NCAR/FV3/pull/176
#283