add calculation of cumulative_change_in_X_due_to_PBL to MYNN PBL wrapper#267
Merged
Merged
Conversation
climbfuji
approved these changes
Jun 11, 2019
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Approved for v3.0 release. Can I ask for a similar PR for the master branch, please (I can run the tests in the near future)? Thanks.
Collaborator
Author
|
@climbfuji OK: #268 |
hannahcbarnes
pushed a commit
to hannahcbarnes/ccpp-physics
that referenced
this pull request
Aug 3, 2022
…ork and ccpp-physics (NCAR#267) - Fix conditional allocation of several gravity wave drag variables, add missing active attributes in CCPP metadata - thanks Evan Kalina - Add `-init=snan,arrays` to Intel DEBUG compiler flags for ccpp-physics, this helps detecting uninitialized variables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added code and variables from GFS_PBL_generic_post to module_MYNNPBL_wrapper.F90 to save PBL tendences of T,u, and v. This is necessary to output tendencies from the MYNN PBL scheme in the CCPP since the GFS_PBL_generic_post scheme is not used after MYNN PBL is called.
Note that tendencies of q are not calculated here since they have been commented out throughout the physics code.
This code has been tested using the SCM only with {lssav,ldiag3d}=T on Mac(GNU), Theia(Intel), and Cheyenne(Intel) only using the SCM_GSD_v0 suite. This code should be tested with RTs if wanted in the master branch.