Skip to content

CCPP-compliant Grell-Freitas convection scheme#166

Merged
climbfuji merged 11 commits into
NCAR:masterfrom
climbfuji:gf_haiqinli_with_mods_from_dom
Oct 10, 2018
Merged

CCPP-compliant Grell-Freitas convection scheme#166
climbfuji merged 11 commits into
NCAR:masterfrom
climbfuji:gf_haiqinli_with_mods_from_dom

Conversation

@climbfuji
Copy link
Copy Markdown
Collaborator

This PR is based mostly on the work by @haiqinli and supersedes PR #139. For further details, see below.

haiqinli and others added 11 commits August 8, 2018 17:09
…r_init, add notes about future work, fix names of argument tables, adjust indents, remove debugging print statements
…indents, replace DDTs with Fortran standard variables (components of the DDTs), add interstitial code previously in GFS_physics_driver.F90
…ndents, replace DDTs with Fortran standard variables (components of the DDTs), add interstitial code previously in GFS_physics_driver.F90
@climbfuji
Copy link
Copy Markdown
Collaborator Author

@climbfuji climbfuji requested a review from haiqinli October 5, 2018 23:36
@climbfuji
Copy link
Copy Markdown
Collaborator Author

@haiqinli Can you please provide a paragraph of information (for example like the description in #165) about this PR, which version of the code, what has been left out, what needs to be done etc?

@climbfuji
Copy link
Copy Markdown
Collaborator Author

These PRs were tested successfully on MacOSX with clang+gfortran to give bit-for-bit identical results for the fv3_control run both with and without CCPP compared to the baseline. Attached is also a screenshot of average precipitation rate for a 1h forecast on a C96 mesh, left fv3_control and right fv3_gf (identical to fv3_control, but with GF deep/shallow instead of SAS).

screen shot 2018-10-05 at 5 41 13 pm

The code is up to date with the current reference branches, including the latest Thompson MP PRs.

Todo:

  • 120h forecast fv3_control versus fv3_gf on Theia for C96 mesh
  • 24h forecast on a C384 mesh and/or a 6h forecast on a C768 mesh
  • usual standard regression tests on Theia/Intel

@climbfuji
Copy link
Copy Markdown
Collaborator Author

Standard regression test logs on Theia/Intel, all tests passed.

rt_ccpp_hybrid.log
rt_ccpp_ref.log
rt_ccpp_standalone.log
rt_ccpp_static.log
rt_full.log

@climbfuji
Copy link
Copy Markdown
Collaborator Author

Test of GF versus SAS: 120h integration on C96 mesh, plots of total precipitation [mm/day] for SAS, GF, and SAS-GF.

gf
sas-gf
sas

@climbfuji
Copy link
Copy Markdown
Collaborator Author

This PR is ready to go from my side. If changes need to be made, for example to the standard_name choices, we can either redo the CCPP tests or create a follow-up PR.

@haiqinli
Copy link
Copy Markdown
Collaborator

haiqinli commented Oct 9, 2018

This PR and associated PRs listed below add the Grell-Freitas scale-aware and aerosol-aware convective scheme to CCPP and enable its use in NEMSfv3gfs.

This GF scheme is based on the version in FV3GFS version 1.

Copy link
Copy Markdown
Collaborator

@haiqinli haiqinli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. It is designed to be independent of global models.

@climbfuji
Copy link
Copy Markdown
Collaborator Author

Most of the code was written by Haiqin, I only implemented corrections on top of the original PRs and brought the code up to date. My corrections were reviewed by Haiqin. Merging it now.

@climbfuji climbfuji merged commit db67148 into NCAR:master Oct 10, 2018
@climbfuji climbfuji deleted the gf_haiqinli_with_mods_from_dom branch June 27, 2022 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants