UFS/dev PR#299#1220
Conversation
…emove *_of_new_state (default name refers to 'current' value)
…medmfvdifq return new tendencies and new tendency application block in GFS_PBL_generic_post
- Added tendency variables (`ten_t`, `ten_u`, `ten_v`) for temperature and wind tendencies in SAMF deep and shallow convection schemes. - Updated relevant `.meta` files to reflect changes in variable intent (`inout` -> `in` where appropriate) and added tendencies. - Modified Interstitials (`GFS_DCNV_generic_post`, `GFS_DCNV_generic_pre`, `GFS_SCNV_generic_post`, `GFS_SCNV_generic_pre`) to directly use tendencies instead of saved state variables. - Removed redundant saved variables (`save_u`, `save_v`, `save_t`). - Added `delt` to post interstitials.
…' into feature/tendency_cleanup
…_dimension in GFS_time_vary_pre.scm
…endency paradigm; cleanup saving of states no longer needed
…as removed recently
Updates to progomega option of saSAS convection scheme
grantfirl
requested review from
AndersJensen-NOAA,
andrewgettelman,
cenlinhe,
climbfuji,
dustinswales,
haiqinli,
joeolson42,
lisa-bengtsson,
mdtoyNOAA,
rhaesung and
tanyasmirnova
as code owners
|
Because of the size of this PR, I'd like to test the changes in NEPTUNE before I approve, if possible. |
Of course. I was expecting that. |
hertneky
left a comment
hertneky
left a comment
There was a problem hiding this comment.
Phew, big PR. Looks good. One file had extra white space added that I left a comment on.
I also technically successfully tested this PR on ursa with SCM RTs when I tested my PR367, since it includes this PR.
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Alternatively, declare A, B, and C as scalars. I don't see why they need to be arrays.
Well, they need to be arrays because they are arguments for the scheme. My proposed fix is therefore correct. |
|
@grantfirl grantfirl#8 fixes the rayleigh_damp bug. |
Bug fix in physics/GWD/rayleigh_damp.f: don't mix scalars and rank-2 arrays
9 participants
Description of Changes:
This PR brings over the tendency cleanup changes from ufs-community#299. Please see that PR for details.
Tests Conducted:
UFS RTs - see ufs-community/ufs-weather-model#2810
The results change, but they were within "the noise" as evidenced by plots presented in ufs-community#299
Dependencies:
None
Documentation:
None added.
Issue (optional):
None