GFS_time_vary_pre: check that w3emc uses the expected precision#1152
Closed
climbfuji wants to merge 2 commits into
Closed
GFS_time_vary_pre: check that w3emc uses the expected precision#1152climbfuji wants to merge 2 commits into
climbfuji wants to merge 2 commits into
Conversation
…k that w3emc is using the expected precision
…k that w3emc is using the expected precision
climbfuji
requested review from
dustinswales,
grantfirl and
rhaesung
as code owners
Collaborator
Author
|
@grantfirl @dustinswales Gentle reminder about this PR. |
Member
dustinswales
left a comment
dustinswales
left a comment
There was a problem hiding this comment.
Looks fine to me.
I will make corresponding SCM PR. If RTs pass I will approve.
Collaborator
|
@climbfuji @dustinswales I'm finally getting around to testing #1141 in the UFS. For testing, I'll combine this PR into that (locally at first). Assuming all tests are OK, we can combine PRs and merge together. Then start a PR into ufs/dev to sync up. |
Collaborator
|
Testing the combined code changes in the SCM and UFS is complete and was successful, so I've combined the PRs into another one and will merge shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes:
See #1151
Tests Conducted:
Tested the NRL version of this code.
Dependencies:
None
Documentation:
None
Issue (optional):
Closes #1151
Contributors (optional):
@areinecke and @matusmartini