UFS-dev PR#278#1144
Conversation
…phys_time_vary_timestep_init to ccpp-physics branch mcycle
…mgcycle in gcycle.F90
Bug fix for surface roughness calculation over lakes and sea ice points when wave model is turned on
In Noah-MP, set zero for canopy liquid and canopy ice over glacier
grantfirl
requested review from
AndersJensen-NOAA,
cenlinhe,
dustinswales,
haiqinli,
mdtoyNOAA,
rhaesung and
tanyasmirnova
as code owners
grantfirl
requested review from
hertneky
and removed request for
haiqinli and
tanyasmirnova
grantfirl
requested review from
scrasmussen
and removed request for
AndersJensen-NOAA,
cenlinhe and
mdtoyNOAA
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
I still don't get any requests to review PRs to NCAR ccpp-physics main, just saw this by coincidence. Can this be fixed, please?
I went back and checked the UFS PRs referenced in the PR description. The changes look good, although I focused on the schemes that are in use at NRL and not a lot on the other changes (in particular not the scientific documentation changes - thanks for updating, a lot of work).
One question regarding the URLs for the documentation, but happy to approve.
|
@climbfuji Please re-review because another ufs/dev PR was added into this one (since it doesn't affect the SCM, it is easier to combine them). You should only need to look at db40996 for the gcycle changes. |
Yes, this is good, thanks very much. I had seen the gcycle PR and that all looked great. |
10 participants
Description of Changes:
This PR updates the NCAR/main fork/branch with changes from ufs-community#278 and ufs-community#285.
This contains changes from #1143 until it is merged.
Tests Conducted:
See ufs-community/ufs-weather-model#2723 and ufs-community/ufs-weather-model#2747
Dependencies:
Documentation:
N/A
Issue (optional):
ufs-community#278 addressed the issue originally.
Contributors (optional):
@wzzheng90 @XuLi-NOAA @RuiyuSun