Ufs dev PR#251#1112
Conversation
Sixth reconciliation PR from production/RRFS.v1
Merge NCAR:main to ufs-community:ufs/dev + update GF/C3 for SRW3.0 release
dustinswales
requested review from
Qingfu-Liu,
grantfirl,
haiqinli,
lisa-bengtsson,
mzhangw and
rhaesung
as code owners
|
|
||
| - name: Checkout latest fv3atm | ||
| run: git clone https://github.com/NCAR/fv3atm.git | ||
| run: git clone https://github.com/NOAA-EMC/fv3atm.git |
There was a problem hiding this comment.
Come to think of it, I'm not entirely sure that we need this file anymore since we're not maintaining our own branch of fv3atm? At least when this CI is run in the NCAR repo, it will fail henceforth I think. Wasn't the point of this test to sorta provide a "heads up" that the host (SCM) needs to change metadata somehow when physics PRs are introduced? It's trying to build the current fv3 with the PR branch physics. I guess that might still serve a purpose for the ufs/dev branch.
There was a problem hiding this comment.
Yeah, I think what we want to do is:
In the NCAR:ccpp-physics we should have a CI test that runs prebuild using the SCM metadata.
In the UFS:ccpp-physics we should have a CI test that runs prebuild using the FV3 metadata.
grantfirl
left a comment
grantfirl
left a comment
There was a problem hiding this comment.
Fine as-is. Left a comment about the ci_fv3_ccpp_prebuild workflow.
|
@grantfirl I opened an issue so we dont forget, #1113 |
4 participants
Contains changes from PR #251