Bug fix in physics/GWD/ugwp_driver_v0.F to prevent using uninitialized Bnv2 array in line 350#1104
Merged
grantfirl merged 2 commits intoMar 10, 2025
Conversation
…d Bnv2 array in line 350
climbfuji
requested review from
Qingfu-Liu,
dustinswales,
grantfirl,
mdtoyNOAA and
rhaesung
as code owners
mdtoyNOAA
approved these changes
Dec 4, 2024
Collaborator
Author
|
Ping |
Collaborator
Author
|
@grantfirl @dustinswales Can we please merge this? Thank you! |
grantfirl
approved these changes
Mar 10, 2025
Collaborator
grantfirl
left a comment
grantfirl
left a comment
There was a problem hiding this comment.
I agree with @mdtoyNOAA that this code isn't used anywhere in UFS/SCM. I'll create a PR in ccpp-scm
Collaborator
|
@climbfuji @dustinswales SCM RTs are running here: NCAR/ccpp-scm#565. Assuming everything passes, we can merge. |
Collaborator
Author
|
Thank you, appreciate it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1103. Same bug fix applied in NEPTUNE.