Skip to content

Bug fix in physics/module_sf_noahmp_glacier.F90: only compute glacier albedo in snowalb_bats_glacier if cosz > 0 #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
climbfuji wants to merge 1 commit into from
Closed

Bug fix in physics/module_sf_noahmp_glacier.F90: only compute glacier albedo in snowalb_bats_glacier if cosz > 0 #1091

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions physics/SFC_Models/Land/Noahmp/module_sf_noahmp_glacier.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -971,18 +971,20 @@ subroutine snowalb_bats_glacier (nband,cosz,fage,albsnd,albsni)
albsni(1: nband) = 0.

! when cosz > 0

sl=2.0
sl1=1./sl
sl2=2.*sl
cf1=((1.+sl1)/(1.+sl2*cosz)-sl1)
fzen=amax1(cf1,0.)

albsni(1)=0.95*(1.-c1*fage)
albsni(2)=0.65*(1.-c2*fage)

albsnd(1)=albsni(1)+0.4*fzen*(1.-albsni(1)) ! vis direct
albsnd(2)=albsni(2)+0.4*fzen*(1.-albsni(2)) ! nir direct
! https://github.com/ufs-community/ccpp-physics/issues/227
if (cosz>0) then
sl=2.0
sl1=1./sl
sl2=2.*sl
cf1=((1.+sl1)/(1.+sl2*cosz)-sl1)
fzen=amax1(cf1,0.)

albsni(1)=0.95*(1.-c1*fage)
albsni(2)=0.65*(1.-c2*fage)

albsnd(1)=albsni(1)+0.4*fzen*(1.-albsni(1)) ! vis direct
albsnd(2)=albsni(2)+0.4*fzen*(1.-albsni(2)) ! nir direct
endif

end subroutine snowalb_bats_glacier
! ==================================================================================================
Expand Down