Enclose contents of sfc_nst.f in a module.#10
Closed
christopherwharrop wants to merge 20 commits into
Closed
Conversation
Replace sfc_nst with sfc_nst_run. Add empty sfc_nst_init and sfc_nst_finalize. Add parseable table of sfc_nst argument descriptions. Split nstf_name argument into: nstf_name1, nstf_name4, nstf_name5. Modify call to sfc_nst in GFS_physics_driver.F90 to call sfc_nst_run. Code passes basic canned correctness tests.
Author
|
Supersedes previous pull request for sfc_nst from me. Corrects !!! in table. |
No argument table or doxygen for them yet.
Pass in correct slices of variables from physics driver.
… checker scripts to run correctly
hannahcbarnes
pushed a commit
to hannahcbarnes/ccpp-physics
that referenced
this pull request
Apr 7, 2020
* output nested domain on cubed sphere grid * output native cubed sphere grid for regional fv3 and nested fv3 * add HWRF PBL and surface drag for HAFS (sfc_diff.f, moninedmf.f, GFS_typedefs.F90, GFS_physics_driver.F90 modified) * add back HWRF PBL and sfc drag after master revert fractional land/sea mask * Enable outputing a grid from the write grid component, which is larger than the native computation grid of the nested/regional domain. a. Remove the limitation of the output grid being completely inside the model native compuation grid. b. Mask out the output grid points outside the computation grid with missing values. * update HAFS with HWRF PBL/sfc drag * add option to switch GWD on/off * support/HAFS: Clean up before merging features back the develop branch. * support/HAFS: Change the missing value in FV3GFS_io to default real type.
hannahcbarnes
pushed a commit
to hannahcbarnes/ccpp-physics
that referenced
this pull request
Apr 7, 2020
…e_basedir_builddir_logic dtc/develop: merge gsd/develop, update CCPP prebuild config
grantfirl
pushed a commit
to grantfirl/ccpp-physics
that referenced
this pull request
May 18, 2021
Changes necessary to remove GSD_SURFACE_FLUXES_BUGFIX from ccpp-physics
mzhangw
referenced
this pull request
in mzhangw/ccpp-physics
Sep 21, 2021
remove the iteration loop for Noah MP and implement a new coupling in…
lisa-bengtsson
pushed a commit
to lisa-bengtsson/ccpp-physics
that referenced
this pull request
Oct 28, 2022
Bring external land model support
grantfirl
pushed a commit
that referenced
this pull request
Sep 5, 2024
Changes needed to compile scidoc v7 updates
matusmartini
pushed a commit
to matusmartini/ccpp-physics
that referenced
this pull request
Jan 23, 2026
Comment out prints for large virtual skin theta
matusmartini
pushed a commit
to matusmartini/ccpp-physics
that referenced
this pull request
Jan 23, 2026
* Bug fix: remove invalid active attribute in several metadata files
* create mr2_innl and fixed evaporation for mraerosol
* fixed excessive evap
* Make ozone photochem diagnostics match parametrization terms
The ozone photochemistry parametrization is a first-order Taylor expansion of the net ozone production in three variables. This commit changes the four diagnostics the parametrization manages to match the four terms in the Taylor expansion.
When comparing to the implementation in lines 301-304, note that it is implicit in the model ozone mixing ratio, so line 301 has the first term and the second half of the second term, while the first half of the second term is part of the denominator on line 304.
I could use ozi or ozib for an explicit approximation to that term, but we already calculated the value needed for the implicit calculation actually used for the update.
* Introduce namelist flag to convection/cloud/radiation interaction in GFS suite
* Add missing optional attribute to metadata files ONLY
* Add missing optional attribute to conditionally allocated variables, part 2
* Add missing optional attribute to conditionally allocated variables, part 3
* Add missing optional attribute to conditionally allocated variables, part 4
* Bug fix for physics/MP/GFDL/fv_sat_adj.*: use correct allocation of variables but internally bend everything back to where it's expected (affects some, but not all variables)
* Revert many false optional arguments in metadata files
* Add optional in physics/Interstitials/UFS_SCM_NEPTUNE/GFS_radiation_surface.F90
* Add optional in physics/Interstitials/UFS_SCM_NEPTUNE/sgscloud_radpre.F90
* Add optional in .//physics/GWD/cires_ugwp.F90
* Add optional in physics/Interstitials/UFS_SCM_NEPTUNE/GFS_suite_interstitial_{2,3}.F90
* Add optional .//physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmgp_cloud_overlap.*
* Add optional .//physics/Interstitials/UFS_SCM_NEPTUNE/GFS_phys_time_vary.scm.F90
* Add optional .//physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmgp_cloud_mp.F90
* Bug fixes in physics/GWD/cires_ugwp.F90 and physics/Interstitials/UFS_SCM_NEPTUNE/GFS_suite_interstitial_2.F90
* More bug fixes in physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmgp_cloud_mp.F90 and physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmgp_cloud_overlap.F90
* Add optional attribute to GWD files.
* Add optional attribute to smoke/dust files.
* Add optional attribute to MP files.
* Add optional attribute to Convection files, and MP file omitted from previous committ.
* Add optional attribute to Radiation files.
* Add optional attribute to PBL files.
* Add optional attribute to Surface Model files.
* Add optional attribute to Surface Layer files.
* Add optional attribute to Interstitial schemes.
* Some cleanup, after using Courtney's new scipt
* Omission from previous commit
* Fix the setting of model landmask when interpolating
GLDAS data.
Fixes NCAR#199.
* Small bug fixes in physics/SFC_Models/Lake/Flake/flake_driver.F90 and physics/SFC_Models/Land/RUC/lsm_ruc.F90
* Fix incorrect intents
* Address reviewers comment
* Address reviewers comment
* More bugfixes for optional arguments
* Add optional attribute to several variables in mp_gt_driver
* Add missing OPTIONAL Fortran attribute in internal routines: physics/MP/Thompson/module_mp_thompson.F90 physics/PBL/MYNN_EDMF/module_bl_mynn.F90 physics/SFC_Layer/MYNN/module_sf_mynn.F90
* Add missing optional attributes in physics/CONV/Grell_Freitas/cu_gf_deep.F90
* Initial commit of canopy resistane (rca) in Noah-MP for AQM.
* move calculation of rca to noahmpdrv.F90 from module_sf_noahmplsm (add some output variables in module_sf_noahmplsm subroutines to accomplish this)
* No opt flags for gcycle.F90 with Intel
* Comment out block to nullify local pointers at the end of mp_thompson_run to avoid problems with Intel compiler?
* Remove mistakenly added physics/TODO_DONE.txt
* Add optional arguments to physics/CONV/C3/cu_c3*
* use regular lai rather than lai_eff
* add initialization for variables that are not calculated at Noahmp glacier points
* Reduce optimization for mynnedmf_wrapper.F90
Use -O1 instead of -O0 for gcycle.F90 with Intel
* Bug fix for merra2 aerosol setup in physics/MP/Thompson/mp_thompson.F90
* initiate SciDoc for CCPP-SCM v7
* Update CODEOWNERS
* add BoYang-NOAA to CODEOWNERS for ugwpv1_gsldrag*
* Updated rca calculation with rsmin and rsmax limits.
* fix openACC directive bug in cu_gf_deep.F90
* HR4 GWD update for files drag_suite.F90 ugwpv1_gsldrag.F90 unified_ugwp.F90 module_sf_noahmplsm.F90 noahmpdrv.F90
* Change code format in file module_sf_noahmplsm.F90
* Bug fixes in NoahMP LSM and Noah LSM: rca is an optional argument
* update files noahmpdrv.F90 noahmpdrv.meta module_sf_noahmplsm.F90
* update files module_sf_noahmplsm.F90 noahmpdrv.F90 noahmpdrv.meta module_sf_noahmp_glacier.F90
* fix the compile problem for HR4-GWD-update
* update Noahmp code for HR4
* update GWD code for HR4
* remove spurious metadata changes in drag_suite.meta
* remove some unnecessary variables and add some initialization of outputs
* fix some units in metadata files
* add optional to conditionally-allocated var in GFS_ccpp_suite_sim_pre
* add optional attributes for conditionally-allocated variables in FA MP, MYJ SFC/PBL, remove F77 continuation formatting
* remove unnecessary comment in module_bl_mynn.F90
* save the changes
* save scidoc v7 progress
* save work progress
* save progress
* retract the changes of the Noahmp model
* save scidoc
* code cleanup
* save scidoc progress
* add optional attribute as necessary to arguments in drag_suite_psl subroutine; change upper bound of loop to prevent array bound excursion
* address developer's feedback
* scidoc update
* add seperate page for cellular automata and physics update summary
* scidoc updates
* finalize the suite names
* address Ligia's review
* continue addressing reviews
* more tweaks
* scidoc updates
* Changes for CLM lake to work in CCPP SCM
* implement S. Hong's modification
* address review and fix bugs
* Return if error reading aerosol data
* address Scidoc reviews
* remove problematic print statement in GFS_phys_time_vary.scm.F90
* scidoc updates
* scidoc update
* scidoc
* add acronyms pages and NMLs for PSL options
* minor fix
* add back Doxygen comments for passing ccpp_prebuild.py
* address reviewers' comments
* address comments
* address comments
* add module_mp_radar.F90 as dependency for schemes that need module_mp_thompson as dependency since it is a sub-dependency
* fix compilation errors in YSU PBL and FA MP
* NCAR#10 Add merge-conflict directory to keep track of merge conflicts with
aaef9e0
On branch 10-physics-v7-pre-reorg
* NCAR#10 Fix units for flash frequency
On branch 10-physics-v7-pre-reorg
* NCAR#10 Fix passing of constant argument
On branch 10-physics-v7-pre-reorg
* NCAR#10 Fix passing of seed constants
On branch 10-physics-v7-pre-reorg
* NCAR#10 Fix issues resulting from git merge
On branch 10-physics-v7-pre-reorg
* NCAR#10 Initialize ccpp error handling variables
On branch 10-physics-v7-pre-reorg
* NCAR#10 Fix incorrectly merged logic
On branch 10-physics-v7-pre-reorg
* NCAR#10 Remove optional attribute from meta file
On branch 10-physics-v7-pre-reorg
* NCAR#10 Fix GFS_debug to account for the ccpp-physics updates
On branch 10-physics-v7-pre-reorg
* NCAR#10 Set NF_ALBD in radiation_surface.f
On branch 10-physics-v7-pre-reorg
* NCAR#10 Ignore vim swap files in .gitignore
On branch 10-physics-v7-pre-reorg
* NCAR#10 Hardcode number of surface albedo component arrays
On branch 10-physics-v7-pre-reorg
* NCAR#10 Remove merge-conflicts directory
On branch 10-physics-v7-pre-reorg
* Update physics/physcons.F90
Co-authored-by: Alex Reinecke <patrick.a.reinecke.civ@us.navy.mil>
* Update physics/satmedmfvdifq.F
Co-authored-by: Alex Reinecke <patrick.a.reinecke.civ@us.navy.mil>
* Update physics/satmedmfvdifq.F
Co-authored-by: Alex Reinecke <patrick.a.reinecke.civ@us.navy.mil>
* Update physics/satmedmfvdifq.F
Co-authored-by: Alex Reinecke <patrick.a.reinecke.civ@us.navy.mil>
* Update GFS_rrtmg_pre.F90
On branch 10-physics-v7-pre-reorg
* Uncomment write calls in microphysics
* Update time_vary modules
On branch 10-physics-v7-pre-reorg
* NCAR#10 Add Lake model updates in phys_time_vary
On branch 10-physics-v7-pre-reorg
* Uncomment if-checks for is_initialized in phys_time_vary
On branch 10-physics-v7-pre-reorg
* Update rad_time_vary
On branch 10-physics-v7-pre-reorg
* Fix discrepancies with convective overshooting.
On branch 10-physics-v7-pre-reorg
* Update maximum_hourly_diagnostics.F90
On branch 10-physics-v7-pre-reorg
* Various minor updates
On branch 10-physics-v7-pre-reorg
* Remove leftover line with unused variables
* Remove unused variable
On branch 10-physics-v7-pre-reorg
* NCAR#10 Bugfix to allow for correct setting of NF_ALBD. Remove hardcoded value in meta file
On branch 10-physics-v7-pre-reorg
* NCAR#10 Remove redundant checks in short- and longwave radiation.
On branch 10-physics-v7-pre-reorg
* NCAR#10 Remove duplicate code. Open file only on root rank
On branch 10-physics-v7-pre-reorg
* NCAR#10 Test to see if lat-lon index fix is still needed.
On branch 10-physics-v7-pre-reorg
* Revert " NCAR#10 Test to see if lat-lon index fix is still needed."
This reverts commit c76dcf1356fb30367fbaab027f48e379f2d4c16d.
* NCAR#10 Add a comment explaining NRL bugfix
On branch 10-physics-v7-pre-reorg
* NCAR#10 Improve comment in machine.F
On branch 10-physics-v7-pre-reorg
* Reorganization
* Address comments from review.
* Metafile cleanup
* More cleanup
* More metatdata changes
* Bug fix in metadata
* Omission from previous merge
* More metadata fixes
* NCAR#10 Add constants that were not defined among NST parameters
On branch 10-physics-v7-post-reorg
* NCAR#10 Update ozphys_2015.meta
On branch 10-physics-v7-post-reorg
* NCAR#10 Add neptune meta files
On branch 10-physics-v7-post-reorg
* NCAR#10 Move time_vary files into Interstitials directory
On branch 10-physics-v7-post-reorg
* NCAR#10 Update relative path in time_vary meta files
On branch 10-physics-v7-post-reorg
* Move rte-rrtmgp submodule
* Address reviewers comments.
* Add use clause of ty_gas_concs back which may have been removed due to conflict
resolution. Note it is not used.
On branch 10-physics-v7-post-reorg
* Add constants that are not defined
On branch 10-physics-v7-post-reorg
* Update phys_time_vary file for neptune
On branch 10-physics-v7-post-reorg
* Update address of rrtmgp submodule in .gitmodules file
On branch 10-physics-v7-post-reorg
* Revert " Changes to be committed:"
This reverts commit 532a518.
* Rename other files back. The intent was only rename sfc_nst.F to
sfc_nst.f
On branch 10-physics-v7-pre-reorg
* Add constants that are not defined
On branch 10-physics-v7-post-reorg
* Rename sfc_nst_pre and _post from .f to .f90
On branch 10-physics-v7-pre-reorg
* Update sfc_nst_pre and _post. These files seem they were not tracked by
git
On branch 10-physics-v7-pre-reorg
* Delete sfc_nst post and pre files
On branch 10-physics-v7-post-reorg
* Rename sfc_nst from .f to .f90
On branch 10-physics-v7-pre-reorg
* Update sfc_nst.f90
On branch 10-physics-v7-pre-reorg
* Move sfc_nst pre and post files
On branch 10-physics-v7-post-reorg
* Remove sfc_nst.f at last
On branch 10-physics-v7-post-reorg
* Point RRTMGP to the same place as 10-physics-v7-pre-reorg
On branch 10-physics-v7-post-reorg
* Delete physics/sfc_nst.f90
On branch 10-physics-v7-post-reorg
* Add missing block of code to CMakeLists.txt
On branch 10-physics-v7-pre-reorg
* Add NoahMP table file
On branch 10-physics-v7-pre-reorg
* Move NoahMP table file
On branch 10-physics-v7-post-reorg
* Add namelist_soilveg dependency in lsm_noah.meta file
On branch 10-physics-v7-post-reorg
* Fix cu_ntiedtke from incorrect merge conflict resolution
On branch 26-ccpp-update-to-v7-tag
* Roll back mpicomm handle to integer type
On branch 26-ccpp-update-to-v7-tag
* Update time_vary files
On branch 26-ccpp-update-to-v7-tag
* Fix dimension name in meta data. This was a bug.
On branch 26-ccpp-update-to-v7-tag
* #1466 Fix rinc type float. This caused calling radiation on each time
step on blueback.
Co-Authoed by Alex Reinecke <alex.reinecke@nrlmry.navy.mil>
On branch 26-ccpp-update-to-v7-tag
* Test w3kind when calling in time_vary because of an issue on blueback.
* NCAR#29 Add tune_flag to control cloud tuning in Thompson MP
On branch 26-ccpp-update-to-v7-tag-mp-tune
* NCAR#29 Apply suggestions from review. Thanks to Alex and Dom
On branch 26-ccpp-update-to-v7-tag-mp-tune
* Update physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmg_pre.F90
Co-authored-by: Alex Reinecke <patrick.a.reinecke.civ@us.navy.mil>
* NCAR#29 Add more descriptive name for tuning flag
On branch 26-ccpp-update-to-v7-tag-mp-tune
* Update physics/MP/Thompson/module_mp_thompson.F90
Co-authored-by: Alex Reinecke <patrick.a.reinecke.civ@us.navy.mil>
* NCAR#29 Change the flag to do_mp_cloud_tuning
On branch 26-ccpp-update-to-v7-tag-mp-tune
* Remove erroneous 'use mpi' from physics/MP/Thompson/module_mp_thompson.F90, there is another, correct 'use mpi_f08' further down in the file
---------
Co-authored-by: Dustin Swales <dustin.swales@noaa.gov>
Co-authored-by: Lisa Bengtsson <Lisa.Bengtsson@noaa.gov>
Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com>
Co-authored-by: Grant Firl <grant.firl@noaa.gov>
Co-authored-by: anning.cheng <anning.cheng@noaa.gov>
Co-authored-by: DWesl <22566757+DWesl@users.noreply.github.com>
Co-authored-by: George Gayno <George.Gayno@noaa.gov>
Co-authored-by: drnimbusrain <dr.nimbusrain@gmail.com>
Co-authored-by: Man Zhang <man.zhang@noaa.gov>
Co-authored-by: Qingfu Liu <Qingfu.Liu@noaa.gov>
Co-authored-by: Man Zhang <man.zhang@mzhang-mac1.hsd1.co.comcast.net>
Co-authored-by: Soren Rasmussen <s.c.rasmussen@gmail.com>
Co-authored-by: mzhangw <mzhangw@gmail.com>
Co-authored-by: Alex Reinecke <patrick.a.reinecke.civ@us.navy.mil>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace sfc_nst with sfc_nst_run.
Add empty sfc_nst_init and sfc_nst_finalize.
Add parseable table of sfc_nst argument descriptions.
Split nstf_name argument into: nstf_name1, nstf_name4, nstf_name5.
Modify call to sfc_nst in GFS_physics_driver.F90 to call sfc_nst_run.
Code passes basic canned correctness tests.