Make N m-2 equivalent to Pa#670
Merged
Merged
Conversation
jimmielin
requested review from
climbfuji,
dustinswales,
gold2718,
grantfirl,
mkavulich,
mwaxmonsky and
peverwhee
as code owners
climbfuji
approved these changes
Jul 29, 2025
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Thanks for this contribution! At some point we'll have to think about organizing and ordering these conversions better, but with just three equivalent units so far, we are ok.
peverwhee
approved these changes
Jul 29, 2025
gold2718
approved these changes
Jul 30, 2025
Collaborator
gold2718
left a comment
gold2718
left a comment
There was a problem hiding this comment.
Equivalent as documented in https://jokesoftheday.net/joke-Play-hide-and-go-seek/2015053140
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes N m-2 equivalent to Pa.
Simple change to
unit_conversion.pyto add N m-2 equivalent to Pa and vice-versa.User interface changes?: No
Fixes: no separate issue but I am happy to create one.
Testing:
test removed: none
unit tests: unit and doctests all pass, added one doctest
system tests:
manual testing: manually ran unit tests; will test in CAM-SIMA code that this is added for
This is my first PR to this repository so please let me know if I missed any steps. Thanks!