Skip to content

Remove case sensitivity for variable dimensions #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peverwhee merged 3 commits into from
Jun 3, 2025
Merged

Remove case sensitivity for variable dimensions #660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
43aa1ac
grab dimensions in lower case
Jun 2, 2025
260e093
new approach to case agnostic dimensions
Jun 3, 2025
d956f1b
lowercase local name during parsing as well
Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions scripts/metadata_table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -921,7 +921,7 @@ def parse_variable(self, curr_line, known_ddts, skip_ddt_check=False):
(not MetadataTable.table_start(curr_line)))
if valid_line:
# variable_start handles exception
local_name = MetadataSection.variable_start(curr_line, self.__pobj)
local_name = MetadataSection.variable_start(curr_line, self.__pobj).lower()
else:
local_name = None
# end if
Expand Down Expand Up @@ -1003,7 +1003,7 @@ def parse_variable(self, curr_line, known_ddts, skip_ddt_check=False):
var_ok = False
# end if
# end for
pval.append(dim)
pval.append(dim.lower())
else:
dim_ok = VarDictionary.loop_var_okay(standard_name=dim,
is_run_phase=self.__section_title.endswith("_run"))
Expand All @@ -1014,10 +1014,14 @@ def parse_variable(self, curr_line, known_ddts, skip_ddt_check=False):
var_ok = False
# end if
cone_str = 'ccpp_constant_one:{}'
pval.append(cone_str.format(dim))
pval.append(cone_str.format(dim.lower()))
# end if
# end for
# end if
# Special handling for standard_names (convert to lowercase)
if pname == 'standard_name':
pval = pval.lower()
# end if
# Add the property to our Var dictionary
var_props[pname] = pval
# end if
Expand Down
2 changes: 1 addition & 1 deletion scripts/metavar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,7 +708,7 @@ def call_string(self, var_dict, loop_vars=None):
lname = ""
for item in dim.split(':'):
if item:
dvar = var_dict.find_variable(standard_name=item.lower(),
dvar = var_dict.find_variable(standard_name=item,
any_scope=False)
if dvar is None:
try:
Expand Down
2 changes: 1 addition & 1 deletion test/advection_test/cld_liq.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
[ temp ]
standard_name = temperature
units = K
dimensions = (horizontal_loop_extent, vertical_layer_dimension)
dimensions = (horizontal_loop_extent, vertical_LAYER_dimension)
type = real
kind = kind_phys
intent = inout
Expand Down