Detect invalid horizontal dimensions (loop variables) in metadata for host and schemes#659
Merged
climbfuji merged 8 commits intoMay 22, 2025
Conversation
added 3 commits
May 14, 2025 20:33
…zontal dimensions are correct for the current CCPP phase
…) for host and schemes
added 2 commits
May 14, 2025 20:46
…st/temp_set.meta, ddthost_test/make_ddt.meta
…_var_property_name.meta, sample_files/test_multi_ccpp_arg_tables.meta
climbfuji
force-pushed
the
bugfix/detect_invalid_loop_vars_in_metadata
branch
from
54d46ef to
436531c
Compare
climbfuji
requested review from
dustinswales,
gold2718,
grantfirl,
mkavulich,
mwaxmonsky and
peverwhee
as code owners
dustinswales
approved these changes
May 22, 2025
Member
dustinswales
left a comment
dustinswales
left a comment
There was a problem hiding this comment.
@climbfuji These changes look good to me. Just a small comment on an error message.
peverwhee
approved these changes
May 22, 2025
Collaborator
peverwhee
left a comment
peverwhee
left a comment
There was a problem hiding this comment.
looks good to me - thanks for adding that test also!
Collaborator
Author
|
With approvals from NOAA and CGD (and NRL ...) I'll go ahead and merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect invalid horizontal dimensions (loop variables) in metadata for host and schemes
Detect invalid horizontal dimensions (loop variables) in metadata for host and schemes. For schemes,
horizontal_dimensionis invalid in therunphase, all other options (horizontal_loop_extent,horizontal_loop_begin,horizontal_loop_end) are only valid in therunphase. For host models, onlyhorizontal_dimensionis valid.Tests are added for both scheme and host metadata, and existing tests are fixed, namely bad horizontal dimensions in:
test/unit_tests/sample_files/test_bad_var_property_name.metatest/unit_tests/sample_files/test_multi_ccpp_arg_tables.metatest/capgen_test/make_ddt.metatest/capgen_test/temp_set.metatest/ddthost_test/make_ddt.metatest_prebuild/test_tracked_data/scheme3.metatest_prebuild/test_unit_conv/data.*Further: I commented out test for blocked data structures in
test_prebuild/run_all_tests.sh; this test can no longer be run, since blocked data structures required the host model to define the horizontal dimension for blocked data ashorizontal_loop_extent. This test and all code related to supporting blocked data structures inccpp_prebuild.pywill be removed in a follow-up PR (out of scope of this PR).User interface changes?: No
Fixes #521
Testing: all tests pass
tests added: test that invalid horizontal dimensions are detected correctly for host and scheme metadata
tests removed: commented out blocked data tests for
ccpp_prebuildunit tests:
system tests:
manual testing: