Remove legacy src/ccpp_api.F90 - contains #445 (fix metadata2html.py) and #447 (remove NEMSfv3gfs test scripts)#443
Merged
Conversation
This was referenced Mar 20, 2022
Merged
climbfuji
requested review from
gold2718,
grantfirl and
mkavulich
as code owners
gold2718
approved these changes
Mar 22, 2022
Collaborator
gold2718
left a comment
gold2718
left a comment
There was a problem hiding this comment.
Whew! Finally made it through this review.
Looks okay :)
grantfirl
approved these changes
Mar 31, 2022
Collaborator
grantfirl
left a comment
grantfirl
left a comment
There was a problem hiding this comment.
This looks fine to me. Thanks for pointing out in the description that SCM will need to import ccpp_t from ccpp_types now. I'll make that change in an upcoming PR.
…limbfuji/ccpp-framework into feature/remove_ccpp_api
…ub.com/climbfuji/ccpp-framework into feature/remove_ccpp_api
climbfuji
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove legacy
src/ccpp_api.F90.Note. This PR now (04/10/2022) also contains the changes from #445 and #447 (all approved).
User interface changes? Yes
Models currently importing
ccpp_tfromccpp_apimust get it fromccpp_typesdirectly.Fixes #442
Testing:
I ran the two tests that Julie set up a while back for
ccpp_prebuild.pyin directorytests, both of them passed:The change is also being tested by the ufs-weather-model regression testing system, see ufs-community/ufs-weather-model#1130