Fix metadata2html.py, add some more documentation to ccpp_prebuild.py#438
Merged
Conversation
… ccpp_prebuild.py
climbfuji
requested review from
gold2718,
grantfirl and
mkavulich
as code owners
gold2718
approved these changes
Feb 24, 2022
Collaborator
gold2718
left a comment
gold2718
left a comment
There was a problem hiding this comment.
How easily things break.
Collaborator
Author
Yes, especially when they are not tested/used regularly. capgen will do much better! |
grantfirl
approved these changes
Feb 25, 2022
Collaborator
grantfirl
left a comment
grantfirl
left a comment
There was a problem hiding this comment.
Thanks for the fix, @climbfuji.
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #437, see description there, and provides an additional comment for one subroutine in
ccpp_prebuild.pyUser interface changes?: No
Fixes: #437
Testing:
metadata2html.pyworks for in-source and out-of-source builds