Update master from gsd/develop 2020/11/20#338
Merged
climbfuji merged 14 commits intoNov 24, 2020
Conversation
…elop_20200630 Update master from gsd/develop 2020/06/30
…ter_20200707 Update gsd/develop from NCAR master 2020/07/07
Update gsd/develop from NCAR master
…update_gsd_develop_from_master_20200903
…i/ccpp-framework into update_gsd_develop_from_master_20200903
…0200903 Update gsd/develop from master 2020/10/01
…finalize routines
…without horizontal dimension not supported at this time
…nit_and_finalize Support "unblocked" variables in init and finalize
…ter_20201118 Update gsd/develop from master 2020/11/18
This was referenced Nov 23, 2020
climbfuji
requested review from
gold2718,
grantfirl and
llpcarson
as code owners
climbfuji
changed the title
gold2718
approved these changes
Nov 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
ccpp_prebuild.pyto handle array variables that are independent of the blocking structure in the_initand_finalizecalls. This is required to perform the physics initialization properly.The restrictions are that such variables that do not contain a horizontal dimension cannot depend on the block number - this makes sense, because it would be a waste of memory.
The test and use case for this block of code is the RUC LSM initialization, which has been verified to work correctly in the gsd/develop branch for several months now.
For regression testing, see ufs-community/ufs-weather-model#297
Associated PRs:
#338
NCAR/ccpp-physics#521
NOAA-EMC/ufsatm#202
ufs-community/ufs-weather-model#297