Fix decoding errors in scripts/common.py's execute_cmd#295
Merged
Conversation
climbfuji
added
the
ccpp_prebuild
This was referenced May 21, 2020
Collaborator
Author
|
Note: I flagged this PR and associated PRs as "ready to merge" in case these make it to the top of the commit queue during my two days of holidays. Please do not merge unless agreed upon with @DusanJovic-NOAA and @junwang-noaa. |
gold2718
approved these changes
May 24, 2020
Collaborator
gold2718
left a comment
gold2718
left a comment
There was a problem hiding this comment.
Style comment / suggestion.
Comment on lines
+62
to
+63
| message += ' stdout: "{0}"\n'.format(stdout.decode('ascii', 'ignore').rstrip('\n')) | ||
| message += ' stderr: "{0}"'.format(stderr.decode('ascii', 'ignore').rstrip('\n')) |
Collaborator
There was a problem hiding this comment.
Normally, I would use argument names for optional arguments:
stdout.decode(encoding='ascii', errors='ignore')
Collaborator
Author
There was a problem hiding this comment.
I added the argument names as requested, thanks for the suggestion.
climbfuji
added a commit
to climbfuji/ccpp-framework
that referenced
this pull request
Jun 7, 2020
Fix decoding errors in scripts/common.py's execute_cmd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Associated PRs:
#295
NOAA-EMC/ufsatm#117
NOAA-EMC/NEMS#63
ufs-community/ufs-weather-model#139
For regression testing information, see below ufs-community/ufs-weather-model#139.