Skip to content

Bugfix libxml2 library location macOS, logging message for unit conversions, bugfix for metadata2html.py#241

Merged
climbfuji merged 3 commits into
NCAR:dtc/developfrom
climbfuji:bugfix_libxml2_info_message_unit_conversion
Nov 20, 2019
Merged

Bugfix libxml2 library location macOS, logging message for unit conversions, bugfix for metadata2html.py#241
climbfuji merged 3 commits into
NCAR:dtc/developfrom
climbfuji:bugfix_libxml2_info_message_unit_conversion

Conversation

@climbfuji
Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji commented Nov 18, 2019

This PR is associated and tested with the PRs listed below. For regression testing, see NCAR/ufs-weather-model#3.

Changes for ccpp-framework:

  • scripts/mkcap.py: add logging message when performing unit conversions (addresses Missing log entry for automatic unit conversions #232)
  • src/CMakeLists.txt: bugfix for macOS when specifying libxml2 libraries instead of auto-detecting them (use .dylib suffix instead of .so)
  • scripts/metadata2html.py: update for out-of-source build changes in ufs-weather-model and gmtb-scm; for the ufs-weather-model, the documentation can be generated as follows:
ufs-weather-model$ # batch process for all schemes files in CCPP prebuild config
ufs-weather-model$ ./FV3/ccpp/framework/scripts/metadata2html.py -c FV3/ccpp/config/ccpp_prebuild_config.py -b FV3

ufs-weather-model$ #  for a single file
ufs-weather-model$ ./FV3/ccpp/framework/scripts/metadata2html.py -m FV3/ccpp/physics/physics/sascnvn.meta -o FV3/ccpp/physics/physics/

@climbfuji
Copy link
Copy Markdown
Collaborator Author

The output written to the ccpp_prebuild.py logs look like this:

INFO: Automatic unit conversion from m to um for effective_radius_of_stratiform_cloud_ice_particle_in_um before entering MODULE_mp_thompson SCHEME_mp_thompson SUBROUTINE_mp_thompson_run
INFO: Automatic unit conversion from m to um for effective_radius_of_stratiform_cloud_liquid_water_particle_in_um before entering MODULE_mp_thompson SCHEME_mp_thompson SUBROUTINE_mp_thompson_run
INFO: Automatic unit conversion from m to um for effective_radius_of_stratiform_cloud_snow_particle_in_um before entering MODULE_mp_thompson SCHEME_mp_thompson SUBROUTINE_mp_thompson_run

@climbfuji
Copy link
Copy Markdown
Collaborator Author

climbfuji commented Nov 18, 2019

@climbfuji climbfuji marked this pull request as ready for review November 20, 2019 14:41
@climbfuji climbfuji changed the title Bugfix libxml2 library location macOS and logging message for unit conversions Bugfix libxml2 library location macOS, logging message for unit conversions, bugfix for metadata2html.py Nov 20, 2019
Copy link
Copy Markdown
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@climbfuji climbfuji merged commit 6da7808 into NCAR:dtc/develop Nov 20, 2019
@climbfuji climbfuji deleted the bugfix_libxml2_info_message_unit_conversion branch June 27, 2022 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants