ccpp_prebuild: validate suite name in static build, fix legacy Fortran code, improve error handling#240
Closed
climbfuji wants to merge 19 commits into
Closed
Conversation
It now resides in ccpp-doc master branch.
…ired for parallel cmake builds in NEMSfv3gfs
Remove CCPPtechnical directory from ccpp-framework master branch.
…dard libraries instead of deprecated or manual tools
…m/climbfuji/ccpp-framework into update_master_from_gmtb_develop_20191016
…velop_20191016 Update master from gmtb/develop 2019/10/16
…missing configuration variables
Bugfix for travis test in schemes/check/ccpp_prebuild_config.py; add …
… name in suite definition file
climbfuji
changed the title
Codecov Report
@@ Coverage Diff @@
## master #240 +/- ##
=======================================
Coverage 47.28% 47.28%
=======================================
Files 14 14
Lines 1343 1343
=======================================
Hits 635 635
Misses 708 708Continue to review full report at Codecov.
|
Bugfix #2 for travis test in schemes/check/ccpp_prebuild_config.py
climbfuji
requested review from
gold2718,
grantfirl and
llpcarson
as code owners
Collaborator
Author
|
@gold2718 you were added as reviewer by mistake, this PR is for our development branches. Please ignore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in scripts/mkstatic.py:
These changes have been tested with gmtb-scm NCAR/ccpp-scm#136 and ufs-weather-model when creating dtc/develop (i.e., this PR was pulled into the ccpp-framework gmtb/develop branch after merging master into gmtb/develop, and dtc/develop was created from that merged code). As such, this PR does not need to be merged anymore.