gmtb/develop: update from master, address issues from previous commit#224
Merged
Conversation
…to reflect: a) The gmtb-scm code repository is now public. b) The EMC NEMS repository is no longer in VLab as it has been moved to GitHub in August 2019. GMTB is forking this repository and no longer mirrorring it. c) Given that the CCPP-enabling capabilities in the FV3, NEMS, and NEMSfv3gfs repositories were committed to EMC's master in July 2019, the primary branch for CCPP development in the GitHub.com/NCAR fork or mirrors is no longer a special GMTB area (gmtb/ccpp) but is now the primary code (master for NEMSfv3gfs and FV3 and develop for NEMS). The difference in terminogy (master versus develop) is due to the transition of EMC's codes to GitHub and use of GitFlow (NEMS is now on GitHub using GitFlow, so develop is the proper origin/upstream). d) A clarification on Section 7.4.1 (Creating a PR) asking developers to, when relevant, note in the PR message the existence of associated PRs in separate repositories.
… reflect changes in the NEMSfv3gfs regression tests implemented when the CCPP-enabling changes to FV3, NEMS, and NEMSfv3gfs were committed to EMC master in July 2019.
- Fix typo and comma use - Make a few sentences more clear - Fix bug in git clone command
…ession test script rt.sh.
…Test script rt.sh.
Tech doc updates (for master)
add Julie as a codeowner
…velop_20190909 master: update from gmtb develop 2019/09/09
…call to check_fortran_type, but do not throw an error in case a DDT is not registered
…into myj_with_dom_mods
Collaborator
Author
Collaborator
Author
|
See https://github.com/NCAR/NEMSfv3gfs/pull/249 for regression testing. |
grantfirl
approved these changes
Sep 19, 2019
Collaborator
grantfirl
left a comment
grantfirl
left a comment
There was a problem hiding this comment.
Looks OK to me with a cursory look. What is the protocol for updating the HTML actually being served on the website corresponding to these RST changes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.