ccpp_prebuild: out-of-source builds for parallel cmake builds (target master)#218
Conversation
climbfuji
requested review from
gold2718,
grantfirl and
llpcarson
as code owners
|
Associated PRs: #218 (previously branches "cmake_rt_gnu_and_ccpp" of gerrit:FV3 and gerrit:NEMSfv3gfs, but these are now out of date) |
gold2718
left a comment
gold2718
left a comment
There was a problem hiding this comment.
Some repeated def write methods but otherwise looks okay (as long as my question at the end does not stir up any angst).
| def write_sourcefile(self, source_filename): | ||
| success = True | ||
| filepath = os.path.split(source_filename)[0] | ||
| if not os.path.isdir(filepath): |
There was a problem hiding this comment.
Good catch, thanks! I will add the guard here as well.
climbfuji
changed the title
…ired for parallel cmake builds in NEMSfv3gfs
climbfuji
force-pushed
the
ccpp_prebuild_out_of_source_build
branch
from
77035ae to
1358ecf
Compare
|
This PR is no longer required, however we should keep it for further reference. The changes for the CCPP out of source build are now contained in ufs-community/ufs-weather-model#1 and associated PRs. The changes specific to the cmake_rt approach need to be consolidated with the new cmake version that EMC is working on (based on their separate ongoing efforts) and merged into the new fv3atm and ufs-weather-model repositories. |
2 participants
Modifications of ccpp_prebuild.py to support out-of-source builds for static CCPP builds, required for parallel cmake builds in NEMSfv3gfs.
Backward compatible for in-source builds for both static and dynamic builds.