Skip to content

Unit conversion error verbosity#216

Merged
climbfuji merged 1 commit into
NCAR:gmtb/developfrom
grantfirl:unit_conversion_error_verbosity
Aug 22, 2019
Merged

Unit conversion error verbosity#216
climbfuji merged 1 commit into
NCAR:gmtb/developfrom
grantfirl:unit_conversion_error_verbosity

Conversation

@grantfirl
Copy link
Copy Markdown
Collaborator

add the variable standard name and container to the exception message generated by a unit conversion failure for user-friendliness

… generated by a unit conversion failure for user-friendliness
@grantfirl
Copy link
Copy Markdown
Collaborator Author

addresses issue #215

@climbfuji
Copy link
Copy Markdown
Collaborator

Thanks very much for addressing this. I think this doesn't require running the regression tests. Can you confirm that it compiles and spits out the desired error message for the case that you reported in #215 ?

@grantfirl
Copy link
Copy Markdown
Collaborator Author

I used the error message to debug (it works) and it compiles fine on Theia.

Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@climbfuji climbfuji merged commit f8a69b1 into NCAR:gmtb/develop Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants