Add GF cps for CCPP-FV3#119
Merged
Merged
Conversation
haiqinli
requested review from
climbfuji,
grantfirl and
llpcarson
as code owners
climbfuji
reviewed
Aug 9, 2018
Collaborator
There was a problem hiding this comment.
This is pretty straightforward, I am wondering about SCM. We probably need to update/fix PR #80 or add the appropriate changes to this PR and close #80. Also note that PR #80 references an older PR for ccpp-physics (no longer valid?)
Another comment is that we have to create a separate SDF suite_FV3_test_gf.xml (and related to that regression test cases in NEMSfv3gfs - I will do this once the changes are merged in).
Closed
climbfuji
reviewed
Sep 20, 2018
| 'ccpp/physics/physics/gwdps.f' : [ 'slow_physics' ], | ||
| 'ccpp/physics/physics/samfdeepcnv.f' : [ 'slow_physics' ], | ||
| 'ccpp/physics/physics/samfshalcnv.f' : [ 'slow_physics' ], | ||
| # 'ccpp/physics/physics/cu_gf_deep.F90' : [ 'slow_physics' ], |
Collaborator
There was a problem hiding this comment.
I notice that you are using tabs instead of spaces. Please replace all tabs with four spaces
Collaborator
|
I am still missing the suite definition file that contains the calls to the GF convection schemes. |
This was referenced Oct 5, 2018
Collaborator
Collaborator
|
Superseded by #149 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the subroutine of Grell-Freitas cps for CCPP-FV3.