Update GitHub NCAR gmtb/develop with GitHub NOAA-EMC develop 2019/10/13#13
Merged
climbfuji merged 1 commit intoOct 15, 2019
Conversation
* Nightly tests on Hera * Remove FV3-MOM6-CICE5 tests from Theia (added on Hera) * Replace hera with hera.intel * Remove Theia and correct Hera directories.
grantfirl
approved these changes
Oct 15, 2019
grantfirl
left a comment
grantfirl
left a comment
There was a problem hiding this comment.
Looks OK to me, although I'm not the most qualified to review this kind of stuff.
Author
|
No worries, these changes are all from EMC, went through their review process and look ok to me, too. |
climbfuji
pushed a commit
to climbfuji/NEMS
that referenced
this pull request
Nov 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated PRs:
https://github.com/NCAR/FV3/pull/218
#13
NCAR/ccpp-physics#339
https://github.com/NCAR/NEMSfv3gfs/pull/269
See https://github.com/NCAR/NEMSfv3gfs/pull/269 for regression testing.
Changes for NEMS (all from EMC):