Double diffusion cvmix + additional updates #60
Merged
gustavo-marques merged 35 commits intoMay 23, 2018
Conversation
* I believe there is something wrong (halo updates?) with the way this is being done. It needs to be fixed!
The background vertical diff was being added to itself, which is wrong and was leading to a increase in kd_bkgnd over time. This commit fixes this problem.
Total vertical viscosity can now be diagnosed at u and v points.
Variable names are now consistent with what is used in other modules.
* Delete the old double-diffusion code
This commit adds a flag ADD_KV_SLOW (default is FALSE) that controls if the background vertical viscosity in the interior (i.e., tidal + background + shear + convenction) is addded when computing the coupling coefficient. The purpose of this flag is to be able to recover previous answers and it will likely be removed in the future since this option should always be true.
…ouble_diffusion_cvmix
alperaltuntas
added a commit
that referenced
this pull request
Apr 2, 2026
Miscellaneous fixes and updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the option to apply vertical mixing due to double diffusion via CVMix.
In addition, the following updated are included:
Option to smooth Ri using a 1-2-1 filter in
MOM_cvmix_shear. This is done via an input parameterSMOOTH_RI;Option to diagnose total vertical viscosity at u and v points. Variables
Kv_uandKv_uin available.diags;Option to add the contribution of 'slow' varying interior processes (i.e., tidal + background + convection) to the total vertical viscosity. This is done via an input parameter
ADD_KV_SLOW. The purpose of this flag is to be able to recover previous answers and it will likely be removed in the future since this option should always be true. The vertical viscosity from slow varying processes is updated every thermodynamic time-step, while the model solves a fully implicit system for the vertical viscosity of momentum every dynamic (i.e., barotropic) time-step. Since, in most applications, the dynamic time-step is << than the thermodynamic time-step, contributions from slow varying processes are kept constant until the next thermodynamic update.This PR does not change answers (only Intel was tested) recorded for dev-master-candidate-2018-05-15.