Add halo update for Lam2 in wave-enhanced ustar#421
Conversation
|
Thanks @gustavo-marques for this fix. There is at least two related additional issues that tests have revealed: At line 903, IIRC, the legacy wave mixing parameterization clamped the Langmuir multiplier to [1, 5]. Does the new formulation have an equivalent limiter? If not, it seems like we need something similar. As a quick diagnostic, I capped Lam2 at 1e100 and the overflow went away. Not proposing that as the fix, just flagging that a bound does resolve the symptom. The other issue happens in CVMix, and I'll submit an issue/PR separately. |
|
Btw, to reproduce the floating point overflow issue, you may run a GW_JRA case in debug mode with the GNU compiler. |
|
Thanks, @alperaltuntas! Here is where Lam2 is calculated. This is different than the Langmuir multiplier. |
This PR ensures that
Lam2is properly halo-updated before being used in the ustar calculation.#418 fixed a bug in the
get_paramcalls forSTOKES_MOSTandWAVE_ENHANCED_USTAR, but the tests should have failed due to the missing halo update.This PR changes answers.