Skip to content

* Fix bug in pRef used in calculate_CVMix_conv #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alperaltuntas merged 2 commits into from
Sep 26, 2025
Merged

* Fix bug in pRef used in calculate_CVMix_conv #390

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30a6c3f
Change pref to pRef for consistency with rest of code
gustavo-marques Sep 12, 2025
4064dff
* Fix bug in pRef used in calculate_CVMix_conv
gustavo-marques Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/parameterizations/vertical/MOM_CVMix_conv.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ subroutine calculate_CVMix_conv(h, tv, G, GV, US, CS, hbl, Kd, Kv, Kd_aux)
integer :: kOBL !< level of ocean boundary layer extent
real :: g_o_rho0 ! Gravitational acceleration, perhaps divided by density, times unit conversion factors
! [H s-2 R-1 ~> m4 s-2 kg-1 or m s-2]
real :: pref ! Interface pressures [R L2 T-2 ~> Pa]
real :: pRef ! Interface pressures [R L2 T-2 ~> Pa]
real :: rhok, rhokm1 ! In situ densities of the layers above and below at the interface pressure [R ~> kg m-3]
real :: dh_int ! The distance between layer centers [H ~> m or kg m-2]
real :: dh, hcorr ! Limited thicknesses and a cumulative correction [Z ~> m]
Expand Down Expand Up @@ -211,7 +211,7 @@ subroutine calculate_CVMix_conv(h, tv, G, GV, US, CS, hbl, Kd, Kv, Kd_aux)
do K=2,GV%ke

! pRef is pressure at interface between k and km1 [R L2 T-2 ~> Pa].
pRef = pRef + (GV%H_to_RZ*GV%g_Earth) * h(i,j,k)
pRef = pRef + (GV%H_to_RZ*GV%g_Earth) * h(i,j,k-1)
call calculate_density(tv%t(i,j,k), tv%s(i,j,k), pRef, rhok, tv%eqn_of_state)
call calculate_density(tv%t(i,j,k-1), tv%s(i,j,k-1), pRef, rhokm1, tv%eqn_of_state)

Expand Down