Enable stochastic EOS with Bodner#359
Conversation
This commit enables the Stanley parameterization for use with the Bodner23 MLE scheme. It also cleans up logic related to the Stanley parameterization throughout. Finally, it adds some documentation for the `MOM_stoch_eos` module.
|
|
Yes, this is ready. TL;DR: The answer changes are expected, and can old answers can be recovered by setting The occasion for this PR is that we enabled and were using this stochastic correction to the equation of state (EOS) in the original, FFH MLE parameterization. When we switched over to using Bodner the EOS correction was no longer being used, as it wasn't implemented for Bodner. The Bodner scheme simply didn't use the EOS correction, regardless of how you set the input parameters. This PR adds the code to implement the EOS correction for Bodner. So our old results have This PR also cleans up the logic and documentation throughout, but not in a way that changes answers. |
alperaltuntas
left a comment
There was a problem hiding this comment.
I confirmed that USE_STANLEY_ML = False for all of our test cases. However, the restart reproducibility test fails with a runtime error at the initialization of the continuation run. Hopefully the currently open, relevant PRs will resolve that. Otherwise, we can revisit these changes. But for the time being, I'll merge this PR as is.
|
Sounds good. This particular stochastic parameterization has been passing exact restarts for a while, so I agree it's likely that the restart problem is related to the other stochastic parameterization (GM+E). If not I will revisit this. |
|
Is the stochastic parameterization (GM+E) enabled in the tests? I did not think so... |
|
It appears that ESCOMP/MOM_interface#267 broke the stochastic ERS test. This PR is good. |
This commit enables the Stanley parameterization for use with the Bodner23 MLE scheme. It also cleans up logic related to the Stanley parameterization throughout. Finally, it adds some documentation for the
MOM_stoch_eosmodule.