Fix ERS and DIMCS failures for when USE_CR_GRID is on#357
Merged
alperaltuntas merged 4 commits intoApr 28, 2025
Conversation
| endif | ||
|
|
||
| if (MLE_use_PBL_MLD) then | ||
| if (MLE_use_PBL_MLD .or. MLE_use_Bodner) then |
Collaborator
There was a problem hiding this comment.
Should this be MLE_use_PBL_MLD .and. MLE_use_Bodner? I do not think we need to save MLD if MLE_use_Bodner = True and MLE_use_PBL_MLD = False.
Member
Author
There was a problem hiding this comment.
In mixedlayer_restrat_Bodner subroutine, BLD (MLD) and h_MLD is needed regardless of MLE_use_PBL_MLD. Hence, the .or. clause.
| endif | ||
| if (MLE_use_PBL_MLD .or. do_brine_plume .or. use_fpmix .or. & | ||
| use_neutral_diffusion .or. use_hor_bnd_diff) then | ||
| use_neutral_diffusion .or. use_hor_bnd_diff .or. MLE_use_Bodner) then |
Collaborator
There was a problem hiding this comment.
Same here. Do we need to save h_ML even when MLE_use_PBL_MLD = False?
If not, it might make more sense to have:
... .or. use_hor_bnd_diff .or. (MLE_use_Bodner .and. MLE_use_PBL_MLD)
Member
Author
There was a problem hiding this comment.
Similarly, h_MLD is needed by mixedlayer_restrat_Bodner regardless of MLE_use_PBL_MLD.
gustavo-marques
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the exact restart reproducibility (ERS) and dimensional consistency (DIMCS) tests that failed when testing ESCOMP/MOM_interface#252, specifically, when
USE_CR_GRIDis turned on. The fixes are: