Two changes to fpmix indexing#320
Merged
Merged
Conversation
There were two instances of indexing arrays out of bounds: 1. kfsc>=1, but we were looking for iFaceHeight(ksfc-1); I changed this to ksfc instead 2. kbl was set to nint(CS%kOBL(i,j)), and nint() would round up to ke+1 in some instances so I changed this to int(CS%kOBL(i,j,)) instead
hbl_u and hbl_v were not being initialized in vertFPmix unless G%mask2dCu(I,j) and G%mask2dCv(i,J) were > 0.5 (2dCu for hbl_u and 2dCv for hbl_v), but we were using those values to determine whether to compute uInc_u and vInc_v. Now the computation of those two values are also in the if (G%mask2d...) block.
This was referenced Oct 30, 2024
gustavo-marques
approved these changes
Oct 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were two instances of indexing arrays out of bounds:
kfsc>=1, but we were looking foriFaceHeight(ksfc-1); I changed this toiFaceHeight(ksfc)insteadkblwas set tonint(CS%kOBL(i,j)), andnint()would round up toke+1in some instances so I changed this toint(CS%kOBL(i,j,))insteadWe need to verify that these are scientifically correct, they just seemed like easy ways to avoid exceeding the array bounds