fix memory leak in NUOPC State_getImport method#303
Merged
Conversation
mnlevy1981
approved these changes
Sep 23, 2024
Collaborator
mnlevy1981
left a comment
mnlevy1981
left a comment
There was a problem hiding this comment.
There's a test with MARBL in aux_mom, right? So this was bit-for-bit in a case with the MARBL tracers enabled?
Member
Author
|
We have SMS.TL319_t232.G1850MARBL_JRA in aux_mom, which is b4b. If you'd like to run more MARBL tests, I am happy with holding off until you confirm all is well. |
Collaborator
|
Nope, one test is plenty :) Thanks for tracking this down and getting the fix in! |
alperaltuntas
pushed a commit
that referenced
this pull request
Apr 2, 2026
* Updates for failing tests 1. with DO_SKEB=True by default, we need to turn it off in the no_stoch_physics test 2. In order for ERI tests to pass, need stochini=True for hybrid runs * Problem was branch runs, not hybrids
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the memory leak introduced with #157
testing: aux_mom.derecho b4b