MARBL: convert salt_flux to tracer flux and add to STF#298
Merged
Conversation
This is done for DIC, ALK, and related tracers. This mimics uptake and release of these tracers by sea ice.
Member
|
@klindsay28 Is this PR ready to be reviewed and merged? |
Collaborator
Author
|
Yes, it's ready for review. |
correct some indentation issues
mnlevy1981
approved these changes
Aug 30, 2024
Collaborator
mnlevy1981
left a comment
mnlevy1981
left a comment
There was a problem hiding this comment.
@klindsay28 and I walked through these changes, and it looks good to me.
alperaltuntas
added a commit
that referenced
this pull request
Apr 2, 2026
* Use refactored remapping scheme (C_PPM_CW) * Add stochastic backscatter diagnostics * Use pressure gradient force bugfix * Turn off Stochastic EOS (aka Stanley parameterization) in GM/Redi * Set WIND_STAGGER = "A" * Set OCNSKEB_LSCALE = 300e3 * Enable Smagorinsky Laplacian in the workhorse configuration * Set DEPTH_SCALED_KHTH_H0 = 500 in the workhorse * Set ntrunc = 192 in input_nml * Set RAD_EARTH to be the same as in shr_const_mod.F90 * Update reference depth used to calculate MLD * Enable SKEB in the workhorse configuration * Update KPP settings for the workhorse * Update MLE settings for the workhorse * Update convection settings for the workhorse * Update interior mixing settings for the workhose * Update MEKE_GEOMETRIC_ALPHA for the workhose Setting MEKE_GEOMETRIC_ALPHA = 0.06 significantly improves the Southern Ocean MLD biases while keeping a good ACC transport. We will use this value in alpha07g, but it will be revisited during the tuning phase. * Set EQN_OF_STATE = "WRIGHT_FULL" The new default for EQN_OF_STATE is "WRIGHT_FULL" and that's what we want in alpha07g. We will explicitly set this in MOM_interface to 1) document this change, and 2) keep control of which EQN_OF_STATE is being used, in case the default changes again in the future. I did a clean timing comparison between EQN_OF_STATE = "WRIGHT" (simplified version) and EQN_OF_STATE = "WRIGHT_FULL". The differences are within machine uncertainty, so we will proceed with using WRIGHT_FULL in the next tag. EQN_OF_STATE = "WRIGHT_FULL" Model Throughput: 13.84 simulated_years/day EQN_OF_STATE = "WRIGHT" Model Throughput: 13.63 simulated_years/day * Set new defaults for HYCOM1 files in the workhorse * Add new files in the input_data_list * Update server and error message * correct max layer thickness file path and add it to input_data_list * revert REMAPPING_SCHEME change and correct MAXIMUM_INT_DEPTH_CONFIG file path * attempt to fix check_input_data_repo --------- Co-authored-by: alperaltuntas <alperaltuntas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is done for DIC, ALK, and related tracers.
This mimics uptake and release of these tracers by sea ice.
This changes answers for cases with MARBL, but not otherwise.