Modify NUOPC cap to accept separate glc runoff fluxes#288
Conversation
| endif | ||
|
|
||
| ! add liquid glc runoff flux via rof | ||
| if (associated(IOB%lrunoff_glc)) then |
There was a problem hiding this comment.
We should keep these new fields separate in fluxes and not under fluxes%lrunoff and fluxes%frunoff.
Suggestion:
fluxes%lrunoff_glc(i,j) = fluxes%lrunoff_glc(i,j) + kg_m2_s_conversion * IOB%lrunoff_glc(i-i0,j-j0) * G%mask2dT(i,j)
fluxes%frunoff_glc(i,j) = fluxes%frunoff_glc(i,j) + kg_m2_s_conversion * IOB%frunoff_glc(i-i0,j-j0) * G%mask2dT(i,j)
|
Thanks for this PR, @alperaltuntas! Are the changes in src/initialization/MOM_shared_initialization.F90 intended? In addition to what I mentioned above, we also need to:
We should only account for
|
…ds for lrunoff_glc and frunoff_glc.
6b3720c to
32f7d24
Compare
|
@gustavo-marques I just pushed a commit here and a PR to CMEPS (ESCOMP/CMEPS#489) to address your comments. One outstanding task is to determine what to do with the diagnostics associated with |
|
These are the new available diagnostics: |
gustavo-marques
left a comment
There was a problem hiding this comment.
One minor suggestion: only make the new diagnostics available if GLC is active.
This PR addresses issue #281
Changes made:
.true.. If EMC folks decide the import these fluxes in the same way in the future, the import statements can be taken out of the if-blocks.