Option to taper neutral diffusion#248
Merged
alperaltuntas merged 5 commits intoAug 23, 2023
Merged
Conversation
This commit adds the option to apply a linear decay in the neutral diffusion fluxes within a transition zone defined by the boundary layer depths of adjacent columns. This option is controlled by a new parameter NDIFF_TAPERING, which is only available when NDIFF_INTERIOR_ONLY=True. By default NDIFF_TAPERING=False and answers are bitwise identical.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev/ncar #248 +/- ##
============================================
- Coverage 37.07% 37.04% -0.04%
============================================
Files 264 264
Lines 74421 74475 +54
Branches 13780 13787 +7
============================================
- Hits 27592 27589 -3
- Misses 41739 41791 +52
- Partials 5090 5095 +5
☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
@alperaltuntas; this PR is ready for review. |
Simplifies and reduces the code by adding hbd to the neutral diffusion contril structure. This avoid the need to "extract" hbl multiple times. Answers are bitwise indenticals.
Member
|
LGTM. Did you run the test sute? |
Collaborator
Author
|
I did not test the entire suit, only GMOM JRA. I can do it now or we can do it once I create a follow-up PR adding the vertical structure in KHTR. |
Collaborator
Author
|
This PR is ready for review. |
alperaltuntas
approved these changes
Aug 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the option to apply a linear decay in the neutral diffusion fluxes within a transition zone defined by the boundary layer depths of adjacent columns, as in Fig. 2a from Marques et al., (2023). This option is controlled by a new parameter
NDIFF_TAPERING, which is only available whenNDIFF_INTERIOR_ONLY=True. By default,NDIFF_TAPERING=False, and answers are bitwise identical.