migrate nearly all refs to CFC_cap into MOM_tracer_flow_control and MOM_CFC_cap#242
Conversation
…OM_CFC_cap refs moved out of nuopc cap code, MOM_forcing_type, MOM_variables call CFC_cap_set_forcing in call_tracer_set_forcing add call to call_tracer_set_forcing in nuopc cap add arguments to call_tracer_set_forcing increase width in MOM_CFC_cap unit test output correct typo in oil_tracer
| endif | ||
|
|
||
| if (do_thermo) & | ||
| call call_tracer_set_forcing(OS%sfc_state, OS%fluxes, OS%Time, & |
There was a problem hiding this comment.
Is this call needed when USE_CFC_CAP=False? Does it change answers for cases without CFCs?
There was a problem hiding this comment.
It doesn't change answers for cases without CFCs, because call_tracer_set_forcing at this point only calls CFC_cap_set_forcing, and only if USE_CFC_CAP=True.
But I think it makes sense to 'always' call_tracer_set_forcing, so that if hooks to other tracers modules are added to it, like for MARBL tracers, the call to call_tracer_set_forcing doesn't get complicated.
I put always in quotes because of the do_thermo check. I put it inside the do_thermo check to be consistent with how we were previously calling CFC_cap_fluxes. The call to CFC_cap_fluxes was inside convert_IOB_to_fluxes which is only called if do_thermo=.true..
There was a problem hiding this comment.
Thanks for the clarification.
|
I approve this PR. |
2 participants
refs moved out of nuopc cap code, MOM_forcing_type, MOM_variables
call CFC_cap_set_forcing in call_tracer_set_forcing
add call to call_tracer_set_forcing in nuopc cap
add arguments to call_tracer_set_forcing
increase width in MOM_CFC_cap unit test output
correct typo in oil_tracer
failures from aux_mom cheyenne_intel:
NLCOMP failures for all tests
diag_table differs from baseline, but appears to be because of diff in casename in diag_table