* Fixes latent heat contribution from fprec and frunoff (MCT and NUOPC)#174
Merged
Merged
Conversation
This patch fixes a sign bug, in both MCT and NUOPC, when accounting for the latent heat from fprec and frunnoff. Following MOM6's definition, both fprec and frunoff are > 0 into the ocean. Therefore, the latent heat associated with these terms should be negative.
|
@gustavo-marques thanks for the information, I assume this fixing will be pushed back to GFDL after their FMS2 PR |
Collaborator
Author
|
@jiandewang yes, but this might take some time to happen. |
alperaltuntas
approved these changes
Jan 21, 2021
Member
alperaltuntas
left a comment
alperaltuntas
left a comment
There was a problem hiding this comment.
testing: aux_mom.cheyenne - answer changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes a sign bug, in both MCT and NUOPC, when accounting for the latent heat from
fprecandfrunnoff.Following MOM6's definition, both
fprecandfrunoffare > 0 into the ocean. Therefore, the latent heat associated with these terms should be < 0 (i.e., the ocean must lose heat to melt the ice). The diagnostics for these terms (latent_fprec_diag and latent_frunoff_diag) have also been corrected.This PR will change answers for all CESM/MOM6 tests.
Pinging a few folks from EMC since they also use the nuopc cap @DeniseWorthen, @jiandewang