Fix LDT MERRA-2 metforcing unnecessary memory allocation and logs #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a possible unneeded memory allocation in the LDT MERRA-2 metforcing reader. Now, the forcing variables are only allocated when LDT is run in one of these three modes: "Metforce processing" "Metforce temporal downscaling" "Statistical downscaling of met forcing" Also, minor clean-ups are made to log messages for this metforcing. Resolves: NASA-LIS#1634
|
Code looks fine, and it compiles w/o issue. However, there are two issues. |
|
I agree that (1) could be argued either way. I will rebase this onto the public branch. Regarding (2), unfortunately, I do not have an LDT MERRA2 test case. |
|
That did not rebase very cleanly. Because it is not a bug, I will leave it on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a possible unneeded memory allocation in the LDT MERRA-2 metforcing reader. Now, the forcing variables are only allocated when LDT is run in one of these three modes:
"Metforce processing"
"Metforce temporal downscaling"
"Statistical downscaling of met forcing"
Also, minor clean-ups are made to log messages for this metforcing.
Resolves: #1634