Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

fix: fix minor flaws in appCmd sync detection #703

Merged
merged 1 commit into from
Oct 31, 2022
Merged

fix: fix minor flaws in appCmd sync detection #703

merged 1 commit into from
Oct 31, 2022

Conversation

LordOfPolls
Copy link
Member

What type of pull request is this?

  • Non-breaking code change
  • Breaking code change
  • Documentation change/addition
  • Tests change

Description

This pr fixes 2 issues with NAFF sync detection

When syncing a non-global command, the dm_permission attribute is redundant and causes erroneous syncs.
In option comparison, min_length was being compared against max_length causing erroneous syncs

Changes

  • Don't bother comparing dm_permission attribute on non-global commands
  • Actually, compare min against min for options

Checklist

  • I've formatted my code with Black
  • I've ensured my code works on Python 3.10.x
  • I've tested my code

@LordOfPolls LordOfPolls added the Bug::Library A bug in the library label Oct 28, 2022
@LordOfPolls LordOfPolls merged commit 0f50830 into 2.x Oct 31, 2022
@LordOfPolls LordOfPolls deleted the sync-fix branch October 31, 2022 07:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silasary silasary silasary approved these changes

Assignees
No one assigned
Labels
Bug::Library A bug in the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LordOfPolls @silasary