Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

fix: handle no joined_at attribute #680

Merged
merged 1 commit into from
Oct 18, 2022
Merged

fix: handle no joined_at attribute #680

merged 1 commit into from
Oct 18, 2022

Conversation

LordOfPolls
Copy link
Member

What type of pull request is this?

  • Non-breaking code change
  • Breaking code change
  • Documentation change/addition
  • Tests change

Description

In threads, discord no longer always sends a joined_at attribute for members. This handles that.

Resolves #678

Changes

  • joined_at is now optional

Checklist

  • I've formatted my code with Black
  • I've ensured my code works on Python 3.10.x
  • I've tested my code

@LordOfPolls LordOfPolls added the Bug::Discord A bug caused by a discord change label Oct 17, 2022
@LordOfPolls LordOfPolls linked an issue Oct 18, 2022 that may be closed by this pull request
TypeError: Member.__init__() missing 1 required keyword-only argument: 'joined_at' #678
Closed
@AstreaTSS
Copy link
Contributor

AstreaTSS commented Oct 18, 2022 •
edited
Loading

Why is this MISSING instead of None? Just curious.

@LordOfPolls
Copy link
Member Author

Why is this MISSING instead of None? Just curious.

Because the user does have a joined_at value, discord just hasn't sent it to us yet

@LordOfPolls LordOfPolls merged commit 1237435 into dev Oct 18, 2022
@LordOfPolls LordOfPolls deleted the fix-joined-at branch November 14, 2022 09:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Kigstn Kigstn Kigstn approved these changes

Assignees
No one assigned
Labels
Bug::Discord A bug caused by a discord change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: Member.__init__() missing 1 required keyword-only argument: 'joined_at'
3 participants
@LordOfPolls @AstreaTSS @Kigstn